Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c++ std filesystem #4309

Closed

Conversation

RickiNano
Copy link
Contributor

This replaces all uses of boost filesystem with standard c++ filesystem.

A couple of notes:
boost::filesystem::unique_path is not supported in std::filesystem. I have re-written the nano::unique_path function found in /secure/utility.cpp so that it mimics the same behavior.
The "bad_path" unit test fails in LMDB mode when the path input is set to "///" because of the way std::filesystem handles invalid paths. I have removed this test.

Target issue: #4057

Copy link
Contributor

@clemahieu clemahieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed how file opening errors are handled in #4314 which means we won't need to remove the associated test here.

I tried to push a commit on top of this branch but it looks like GitHub branch protection rules prevent this.

Please rebase and this should be good to go.

@RickiNano RickiNano force-pushed the use-c++-std-filesystem branch from 86e311a to efc1dd5 Compare October 18, 2023 18:30
@RickiNano
Copy link
Contributor Author

Github runners are reporting some strange linker errors after rebasing this PR on current develop branch.
I've cherry picked the commits into a new branch and created a new PR here:
#4315
Feel free to merge or close either of them.

@clemahieu clemahieu closed this Oct 18, 2023
@clemahieu
Copy link
Contributor

The linker errors were related to GitHub caching. I cleared the cache and re-ran and they passed so I committed the other PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants