Improve readability for vote handling in active_transactions #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decomposed the `vote` method into smaller methods. - Separated hash categorisation, inactive vote handling, vote processing, and republishing logic for clarity and maintainability. - Enhanced readability by reducing the complexity of the primary vote processing function.
- Rename variables for clarity: `process` to `active_elections_hashes`, and `inactive` to `inactive_hashes`. - Simplify hash categorization in `categorize_hashes` by removing the recently_confirmed_counter logic. - Introduce `no_new_votes_present` method to check for replay votes based on recent confirmations.
…lity - Renamed `process_votes` method to `handle_active_votes` to better convey its responsibility. - Integrated the handling of `nano::vote_code::indeterminate` and subsequent replay check directly within the `handle_active_votes` method.
- rename `process` into `active_elections_hashes` - rename `inactive`into `inactive_hashes`
gr0vity-dev
force-pushed
the
prs/refactor_act_tx_vote_flow
branch
from
5e3596d to
ad309d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks down the vote method in active_transactions.cpp into more modular functions, with the aim to improve the code's readability and maintainability.
I create this as draft PR to see if such refactors are desirable.