This change creates an scheduler::limiter class which tracks and limits how many elections can be spawned. #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
force-pushed
the
scheduling_limiter
branch
7 times, most recently
from
a85dd4a to
ca0bfdf
Compare
clemahieu
force-pushed
the
scheduling_limiter
branch
5 times, most recently
from
23482f9 to
104d9aa
Compare
… rate limiting is happening.
clemahieu
force-pushed
the
scheduling_limiter
branch
from
104d9aa to
6374df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class is a facade around the active_transactions class and exposes a query scheduler::limiter::available to see if there is capacity available and a method scheduler::limiter::insert which checks for availability before inserting an election. Elections are inserted and tracked by the scheduler::limiter class. Coherency is maintained in a lazy manor by holding weak_ptrs to nano::elections and removing them if the pointer has expired or the election is no longer active as reported by active_transactions.
Previous discussion was on this branch #4133