Add single transaction sanity check.

nanocurrency · Sep 28, 2024 · f929415 · f929415
1 parent dbdf1b1
commit f929415
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/nano/store/rocksdb/rocksdb.cpp b/nano/store/rocksdb/rocksdb.cpp
@@ -420,6 +420,7 @@ std::vector<rocksdb::ColumnFamilyDescriptor> nano::store::rocksdb::component::cr
 nano::store::write_transaction nano::store::rocksdb::component::tx_begin_write ()
 {
 	release_assert (transaction_db != nullptr);
+	debug_assert (check_no_write_tx ());
 	return store::write_transaction{ std::make_unique<nano::store::rocksdb::write_transaction_impl> (transaction_db) };
 }
 
@@ -862,6 +863,13 @@ bool nano::store::rocksdb::component::init_error () const
 	return error;
 }
 
+bool nano::store::rocksdb::component::check_no_write_tx () const
+{
+	std::vector<::rocksdb::Transaction *> transactions;
+	transaction_db->GetAllPreparedTransactions (&transactions);
+	return transactions.empty ();
+}
+
 void nano::store::rocksdb::component::serialize_memory_stats (boost::property_tree::ptree & json)
 {
 	uint64_t val;

diff --git a/nano/store/rocksdb/rocksdb.hpp b/nano/store/rocksdb/rocksdb.hpp
@@ -102,6 +102,7 @@ class component : public nano::store::component
 	std::string error_string (int status) const override;
 
 private:
+	bool check_no_write_tx () const;
 	bool error{ false };
 	nano::logger & logger;
 	nano::ledger_constants & constants;