Skip to content

Commit

Permalink
Fix compilation
Browse files Browse the repository at this point in the history
  • Loading branch information
@pwojcikdev
pwojcikdev committed Sep 5, 2024
1 parent 9e86521 commit ddf34f1
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 21 deletions.
60 changes: 45 additions & 15 deletions nano/core_test/ledger.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5529,7 +5529,12 @@ TEST (ledger, cement_unbounded)
auto ctx = nano::test::ledger_diamond (5);
auto & ledger = ctx.ledger ();
auto bottom = ctx.blocks ().back ();
auto confirmed = ledger.confirm (ledger.tx_begin_write (), bottom->hash ());

std::deque<std::shared_ptr<nano::block>> confirmed;
{
auto tx = ledger.tx_begin_write ();
confirmed = ledger.confirm (tx, bottom->hash ());
}
ASSERT_TRUE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
// Check that all blocks got confirmed in a single call
ASSERT_TRUE (std::all_of (ctx.blocks ().begin (), ctx.blocks ().end (), [&] (auto const & block) {
Expand All @@ -5547,26 +5552,37 @@ TEST (ledger, cement_bounded)
auto & ledger = ctx.ledger ();
auto bottom = ctx.blocks ().back ();

// This should only cement some of the dependencies
auto confirmed1 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 3);
std::deque<std::shared_ptr<nano::block>> confirmed1, confirmed2, confirmed3;

{
// This should only cement some of the dependencies
auto tx = ledger.tx_begin_write ();
confirmed1 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 3);
}
ASSERT_FALSE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_EQ (confirmed1.size (), 3);
// Only topmost dependencies should get cemented during this call
ASSERT_TRUE (std::all_of (confirmed1.begin (), confirmed1.end (), [&] (auto const & block) {
return ledger.dependents_confirmed (ledger.tx_begin_read (), *block);
}));

// This should cement a few more dependencies
auto confirmed2 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 16);
{
// This should cement a few more dependencies
auto tx = ledger.tx_begin_write ();
confirmed2 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 16);
}
ASSERT_FALSE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_EQ (confirmed2.size (), 16);
// Only topmost dependencies should get cemented during this call
ASSERT_TRUE (std::all_of (confirmed2.begin (), confirmed2.end (), [&] (auto const & block) {
return ledger.dependents_confirmed (ledger.tx_begin_read (), *block);
}));

// This should cement the remaining dependencies
auto confirmed3 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 64);
{
// This should cement the remaining dependencies
auto tx = ledger.tx_begin_write ();
confirmed3 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 64);
}
ASSERT_TRUE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_LE (confirmed3.size (), 64);
// Every block in the ledger should be cemented
Expand All @@ -5575,41 +5591,55 @@ TEST (ledger, cement_bounded)
}));
}

// Tests that bounded cementing works when mumber of blocks is large but tree height is small (recursion stack is small)
// Tests that bounded cementing works when number of blocks is large but tree height is small (recursion stack is small)
TEST (ledger, cement_bounded_diamond)
{
auto ctx = nano::test::ledger_diamond (4);
auto & ledger = ctx.ledger ();
auto bottom = ctx.blocks ().back ();

// This should only cement some of the dependencies
auto confirmed1 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 3);
std::deque<std::shared_ptr<nano::block>> confirmed1, confirmed2, confirmed3, confirmed4;

{
// This should only cement some of the dependencies
auto tx = ledger.tx_begin_write ();
confirmed1 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 3);
}
ASSERT_FALSE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_EQ (confirmed1.size (), 3);
// Only topmost dependencies should get cemented during this call
ASSERT_TRUE (std::all_of (confirmed1.begin (), confirmed1.end (), [&] (auto const & block) {
return ledger.dependents_confirmed (ledger.tx_begin_read (), *block);
}));

// This should cement a few more dependencies
auto confirmed2 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 16);
{
// This should cement a few more dependencies
auto tx = ledger.tx_begin_write ();
confirmed2 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 16);
}
ASSERT_FALSE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_EQ (confirmed2.size (), 16);
// Only topmost dependencies should get cemented during this call
ASSERT_TRUE (std::all_of (confirmed2.begin (), confirmed2.end (), [&] (auto const & block) {
return ledger.dependents_confirmed (ledger.tx_begin_read (), *block);
}));

// A few more bounded calls should confirm the whole tree
auto confirmed3 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 64);
{
// A few more bounded calls should confirm the whole tree
auto tx = ledger.tx_begin_write ();
confirmed3 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 64);
}
ASSERT_FALSE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_EQ (confirmed3.size (), 64);
// Only topmost dependencies should get cemented during this call
ASSERT_TRUE (std::all_of (confirmed2.begin (), confirmed2.end (), [&] (auto const & block) {
return ledger.dependents_confirmed (ledger.tx_begin_read (), *block);
}));

auto confirmed4 = ledger.confirm (ledger.tx_begin_write (), bottom->hash (), /* max cementing batch size */ 64);
{
auto tx = ledger.tx_begin_write ();
confirmed4 = ledger.confirm (tx, bottom->hash (), /* max cementing batch size */ 64);
}
ASSERT_TRUE (ledger.confirmed.block_exists (ledger.tx_begin_read (), bottom->hash ()));
ASSERT_LT (confirmed4.size (), 64);
// Every block in the ledger should be cemented
Expand Down
7 changes: 5 additions & 2 deletions nano/core_test/request_aggregator.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,11 @@ TEST (request_aggregator, split)
ASSERT_EQ (nano::block_status::progress, node.ledger.process (node.ledger.tx_begin_write (), block));
request.emplace_back (block->hash (), block->root ());
}
// Confirm all blocks
node.ledger.confirm (node.ledger.tx_begin_write (), blocks.back ()->hash ());
{
// Confirm all blocks
auto tx = node.ledger.tx_begin_write ();
node.ledger.confirm (tx, blocks.back ()->hash ());
}
ASSERT_TIMELY_EQ (5s, max_vbh + 2, node.ledger.cemented_count ());
ASSERT_EQ (max_vbh + 1, request.size ());
auto client = std::make_shared<nano::transport::tcp_socket> (node);
Expand Down
4 changes: 2 additions & 2 deletions nano/secure/ledger.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ std::deque<std::shared_ptr<nano::block>> nano::ledger::confirm (secure::write_tr
{
// We must only confirm blocks that have their dependencies confirmed
debug_assert (dependents_confirmed (transaction, *block));
confirm (transaction, *block);
confirm_one (transaction, *block);
result.push_back (block);
}
}
Expand All @@ -878,7 +878,7 @@ std::deque<std::shared_ptr<nano::block>> nano::ledger::confirm (secure::write_tr
return result;
}

void nano::ledger::confirm (secure::write_transaction const & transaction, nano::block const & block)
void nano::ledger::confirm_one (secure::write_transaction & transaction, nano::block const & block)
{
debug_assert ((!store.confirmation_height.get (transaction, block.account ()) && block.sideband ().height == 1) || store.confirmation_height.get (transaction, block.account ()).value ().height + 1 == block.sideband ().height);
confirmation_height_info info{ block.sideband ().height, block.hash () };
Expand Down
2 changes: 1 addition & 1 deletion nano/secure/ledger.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class ledger final

private:
void initialize (nano::generate_cache_flags const &);
void confirm (secure::write_transaction const & transaction, nano::block const & block);
void confirm_one (secure::write_transaction &, nano::block const & block);

std::unique_ptr<ledger_set_any> any_impl;
std::unique_ptr<ledger_set_confirmed> confirmed_impl;
Expand Down
3 changes: 2 additions & 1 deletion nano/test_common/testutil.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ void nano::test::confirm (nano::ledger & ledger, std::shared_ptr<nano::block> co

void nano::test::confirm (nano::ledger & ledger, nano::block_hash const & hash)
{
ledger.confirm (ledger.tx_begin_write (), hash);
auto transaction = ledger.tx_begin_write ();
ledger.confirm (transaction, hash);
}

bool nano::test::block_or_pruned_all_exists (nano::node & node, std::vector<nano::block_hash> hashes)
Expand Down

0 comments on commit ddf34f1

Please sign in to comment.