Database scan improvements (#4734)

* Rename to `database_scan`

* More efficient database scan iteration

* Increase batch size

* Comments

nano/node/CMakeLists.txt

@@ -49,8 +49,8 @@ add_library(
   bootstrap_ascending/throttle.cpp
   bootstrap_ascending/account_sets.hpp
   bootstrap_ascending/account_sets.cpp
-  bootstrap_ascending/iterators.hpp
-  bootstrap_ascending/iterators.cpp
+  bootstrap_ascending/database_scan.hpp
+  bootstrap_ascending/database_scan.cpp
   bootstrap_ascending/peer_scoring.hpp
   bootstrap_ascending/peer_scoring.cpp
   bootstrap_ascending/service.hpp

nano/node/bootstrap_ascending/database_scan.cpp

@@ -0,0 +1,167 @@
+#include <nano/lib/utility.hpp>
+#include <nano/node/bootstrap_ascending/database_scan.hpp>
+#include <nano/secure/common.hpp>
+#include <nano/secure/ledger.hpp>
+#include <nano/secure/ledger_set_any.hpp>
+#include <nano/store/account.hpp>
+#include <nano/store/component.hpp>
+#include <nano/store/pending.hpp>
+
+/*
+ * database_scan
+ */
+
+nano::bootstrap_ascending::database_scan::database_scan (nano::ledger & ledger_a) :
+	ledger{ ledger_a },
+	accounts_iterator{ ledger },
+	pending_iterator{ ledger }
+{
+}
+
+nano::account nano::bootstrap_ascending::database_scan::next (std::function<bool (nano::account const &)> const & filter)
+{
+	if (queue.empty ())
+	{
+		fill ();
+	}
+
+	while (!queue.empty ())
+	{
+		auto result = queue.front ();
+		queue.pop_front ();
+
+		if (filter (result))
+		{
+			return result;
+		}
+	}
+
+	return { 0 };
+}
+
+void nano::bootstrap_ascending::database_scan::fill ()
+{
+	auto transaction = ledger.store.tx_begin_read ();
+
+	auto set1 = accounts_iterator.next_batch (transaction, batch_size);
+	auto set2 = pending_iterator.next_batch (transaction, batch_size);
+
+	queue.insert (queue.end (), set1.begin (), set1.end ());
+	queue.insert (queue.end (), set2.begin (), set2.end ());
+}
+
+bool nano::bootstrap_ascending::database_scan::warmed_up () const
+{
+	return accounts_iterator.warmed_up () && pending_iterator.warmed_up ();
+}
+
+std::unique_ptr<nano::container_info_component> nano::bootstrap_ascending::database_scan::collect_container_info (std::string const & name) const
+{
+	auto composite = std::make_unique<container_info_composite> (name);
+	composite->add_component (std::make_unique<container_info_leaf> (container_info{ "accounts_iterator", accounts_iterator.completed, 0 }));
+	composite->add_component (std::make_unique<container_info_leaf> (container_info{ "pending_iterator", pending_iterator.completed, 0 }));
+	return composite;
+}
+
+/*
+ * account_database_iterator
+ */
+
+nano::bootstrap_ascending::account_database_iterator::account_database_iterator (nano::ledger & ledger_a) :
+	ledger{ ledger_a }
+{
+}
+
+std::deque<nano::account> nano::bootstrap_ascending::account_database_iterator::next_batch (nano::store::transaction & transaction, size_t batch_size)
+{
+	std::deque<nano::account> result;
+
+	auto it = ledger.store.account.begin (transaction, next);
+	auto const end = ledger.store.account.end ();
+
+	for (size_t count = 0; it != end && count < batch_size; ++it, ++count)
+	{
+		auto const & account = it->first;
+		result.push_back (account);
+		next = account.number () + 1;
+	}
+
+	if (it == end)
+	{
+		// Reset for the next ledger iteration
+		next = { 0 };
+		++completed;
+	}
+
+	return result;
+}
+
+bool nano::bootstrap_ascending::account_database_iterator::warmed_up () const
+{
+	return completed > 0;
+}
+
+/*
+ * pending_database_iterator
+ */
+
+nano::bootstrap_ascending::pending_database_iterator::pending_database_iterator (nano::ledger & ledger_a) :
+	ledger{ ledger_a }
+{
+}
+
+std::deque<nano::account> nano::bootstrap_ascending::pending_database_iterator::next_batch (nano::store::transaction & transaction, size_t batch_size)
+{
+	std::deque<nano::account> result;
+
+	auto it = ledger.store.pending.begin (transaction, next);
+	auto const end = ledger.store.pending.end ();
+
+	// TODO: This pending iteration heuristic should be encapsulated in a pending_iterator class and reused across other components
+	// The heuristic is to advance the iterator sequentially until we reach a new account or perform a fresh lookup if the account has too many pending blocks
+	// This is to avoid the overhead of performing a fresh lookup for every pending account as majority of accounts have only a few pending blocks
+	auto advance_iterator = [&] () {
+		auto const starting_account = it->first.account;
+
+		// For RocksDB, sequential access is ~10x faster than performing a fresh lookup (tested on my machine)
+		const size_t sequential_attempts = 10;
+
+		// First try advancing sequentially
+		for (size_t count = 0; count < sequential_attempts && it != end; ++count, ++it)
+		{
+			if (it->first.account != starting_account)
+			{
+				break;
+			}
+		}
+
+		// If we didn't advance to the next account, perform a fresh lookup
+		if (it != end && it->first.account != starting_account)
+		{
+			it = ledger.store.pending.begin (transaction, { starting_account.number () + 1, 0 });
+		}
+
+		debug_assert (it == end || it->first.account != starting_account);
+	};
+
+	for (size_t count = 0; it != end && count < batch_size; advance_iterator (), ++count)
+	{
+		auto const & account = it->first.account;
+		result.push_back (account);
+		next = { account.number () + 1, 0 };
+	}
+
+	if (it == end)
+	{
+		// Reset for the next ledger iteration
+		next = { 0, 0 };
+		++completed;
+	}
+
+	return result;
+}
+
+bool nano::bootstrap_ascending::pending_database_iterator::warmed_up () const
+{
+	return completed > 0;
+}

nano/node/bootstrap_ascending/database_scan.hpp

@@ -0,0 +1,61 @@
+#pragma once
+
+#include <nano/lib/numbers.hpp>
+#include <nano/node/fwd.hpp>
+#include <nano/secure/pending_info.hpp>
+
+#include <deque>
+
+namespace nano::bootstrap_ascending
+{
+struct account_database_iterator
+{
+	explicit account_database_iterator (nano::ledger &);
+
+	std::deque<nano::account> next_batch (nano::store::transaction &, size_t batch_size);
+	bool warmed_up () const;
+
+	nano::ledger & ledger;
+	nano::account next{ 0 };
+	size_t completed{ 0 };
+};
+
+struct pending_database_iterator
+{
+	explicit pending_database_iterator (nano::ledger &);
+
+	std::deque<nano::account> next_batch (nano::store::transaction &, size_t batch_size);
+	bool warmed_up () const;
+
+	nano::ledger & ledger;
+	nano::pending_key next{ 0, 0 };
+	size_t completed{ 0 };
+};
+
+class database_scan
+{
+public:
+	explicit database_scan (nano::ledger &);
+
+	nano::account next (std::function<bool (nano::account const &)> const & filter);
+
+	// Indicates if a full ledger iteration has taken place e.g. warmed up
+	bool warmed_up () const;
+
+	std::unique_ptr<nano::container_info_component> collect_container_info (std::string const & name) const;
+
+private: // Dependencies
+	nano::ledger & ledger;
+
+private:
+	void fill ();
+
+private:
+	account_database_iterator accounts_iterator;
+	pending_database_iterator pending_iterator;
+
+	std::deque<nano::account> queue;
+
+	static size_t constexpr batch_size = 512;
+};
+}