Rocksdb overhaul and clean up #2240

Job	Run time
macOS [UBSAN] [lmdb \| clang]	27m 27s
macOS [ASAN] [lmdb \| clang]	29m 5s
macOS [TSAN] [lmdb \| clang]	33m 10s
macOS [UBSAN] [rocksdb \| clang]	25m 54s
macOS [ASAN] [rocksdb \| clang]	40m 50s
Linux [UBSAN] [lmdb \| clang]	42m 10s
macOS [TSAN] [rocksdb \| clang]	53m 51s
Linux [ASAN] [lmdb \| clang]	43m 10s
Linux [ASAN_INT] [lmdb \| clang] (Errors Ignored)	39m 45s
Linux [TSAN] [lmdb \| clang]	42m 50s
Linux [LEAK] [lmdb \| clang] (Errors Ignored)	42m 8s
Linux [UBSAN] [rocksdb \| clang]	50m 37s
Linux [ASAN] [rocksdb \| clang]	59m 9s
Linux [ASAN_INT] [rocksdb \| clang] (Errors Ignored)	59m 13s
Linux [LEAK] [rocksdb \| clang] (Errors Ignored)	57m 47s
	10h 47m 6s

Provide feedback