Extractor changes. #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devw4r
commented
Jul 27, 2024
devw4r
commented
- Implement -a --alpha arg in order to do the complete extraction process, bvh plus everything found on alpha World/Maps.
- Add missing maps to MapViewer.
- Wrap some directory create calls on TryCatch clause. This is mostly to give feedback about not having access rights to the selected output path but it could also throw on invalid path.
- Implement -a --alpha in order to do the complete extraction process, bvh plus everything found on alpha World/Maps. - Add missing maps to MapViewer.
- Wrap some directory create calls on TryCatch clause. This is mostly to give feedback about not having access rights to the selected output path but it could also throw on invalid path.
|
I don't really like the alpha-specific code. This seems more like an integration task, and therefore code that should live in the alpha core. I'd prefer to be as agnostic to version as possible. The only places with special handling for the alpha right now are where it's required for parsing. |
|
👺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.