Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix redundant 'the' in readme.md #1931

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

vimkim
Copy link
Contributor

@vimkim vimkim commented Jun 10, 2024

A typo fix proposal for #1930

the compiled the user -> the user-compiled

@vimkim vimkim force-pushed the docs/fix-readme-redundant-the branch from 704d4ee to 2cdc0ee Compare June 10, 2024 11:54
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@honggyukim
Copy link
Collaborator

Hi @vimkim, your commit message looks something missing as follows.

From 2cdc0eec2218d6cd0a9012ba98e3db1afa8a3d00 Mon Sep 17 00:00:00 2001
From: Daehyun Kim <[email protected]>
Date: Mon, 10 Jun 2024 20:50:38 +0900
Subject: [PATCH] docs: fix redundant  in readme.md

Signed-off-by: Daehyun Kim <[email protected]>

Maybe you wantted to make it docs: fix redundant "the" in README.md.

You can directly check it at https://github.com/namhyung/uftrace/pull/1931.patch.

@vimkim vimkim force-pushed the docs/fix-readme-redundant-the branch from 2cdc0ee to 77890d7 Compare June 15, 2024 11:04
@vimkim
Copy link
Contributor Author

vimkim commented Jun 15, 2024

Thanks for pointing that out. I mistakenly used backticks (`) to wrap around 'the'. I learned I should never use backticks inside a commit message.

Copy link
Collaborator

@honggyukim honggyukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks good to me!

@honggyukim honggyukim merged commit 354c270 into namhyung:master Aug 14, 2024
3 checks passed
@vimkim vimkim deleted the docs/fix-readme-redundant-the branch August 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants