-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/ko: Translate INSTALL.md in Korean #1809
base: master
Are you sure you want to change the base?
Conversation
Hello, @SEOKMIN83 |
Sorry, I'll fix it tomorrow. |
I've just looked at it roughly. @paranlee @MichelleJin12 Could you review this if the translation is sensible? |
Sure, I will review it and get reviews from other mentees, too. |
That would be nice! |
The translation looks very good. However I have a suggestion for readability. 108: The uftrace implements its own version of configure script to save user preferences. |
Thank you for comment!!!! |
e15bf21
to
75d7acc
Compare
Could you also update the link in Line 139 in b2e3503
^ here |
Hello, @SEOKMIN83, Could you update the commit message not to exceed 72 characters per line? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요,
한국어 맞춤법 검사기를 사용하여 리뷰하였습니다.
검사기 링크: http://speller.cs.pusan.ac.kr/
그리고
uftrace/doc/ko/uftrace-dump.md
Lines 217 to 219 in 58e7307
번역자 | |
====== | |
민지수 <[email protected]> |
이 파일처럼 번역자를 넣으면 좋을 거 같습니다~
I have translated the INSTALL.md documnet for uftrace, which includes a quick usage guide, descriptions and installation methods for various dependency libraries, how to build, and how to configure the environment. I also modified the link in uftrace/README.md. Co-authored-by: Seong Jin Kim <[email protected]> Co-authored-by: Doyun Kim <[email protected]> Co-authored-by: Gichoel Choi <[email protected]> Signed-off-by: SeokMin Kwon <[email protected]>
f3986c7
to
cae3e8f
Compare
Hmm... I guess it's one of those things that got away from our attention while we were waiting for feedback. :) However, I think we should undo the changes to the English before:
after:
Because I think the Korean |
Oops, sorry about that. And I agree with @gicheol to link to Korean doc. |
I have translated the INSTALL.md document for uftrace, which includes a quick usage guide,
descriptions and installation methods for various dependency libraries,
how to build, and how to configure the environment.