-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter: Remove obsolete function add_trigger #1807
filter: Remove obsolete function add_trigger #1807
Conversation
7d25b04
to
201d429
Compare
201d429
to
3b985f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but we don't use refactor:
as a prefix in the commit title. You can get more idea by reading other commit messages by running git log
.
In this case, the prefix could be filter:
because it modifies the filter.h.
@honggyukim Thank you! I'll fix the branch naming and PR again |
No, please reopen this PR and force push to the same branch to update this patch. |
I will reopen this PR. |
Hmm.. the branch is already deleted. |
Sorry, when I renamed the branch in the forked repository, the old branch disappeared - I've restored it now! |
The function add_trigger has been replaced with update_trigger, rendering it unnecessary. This commit removes the now-unused add_trigger function. Signed-off-by: Soyeon Park <[email protected]>
3b985f4
to
58e37d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix!
The function add_trigger has been replaced with update_trigger,
rendering it unnecessary. This commit removes the now-unused
add_trigger function.
related: eeb5d74
Signed-off-by: Soyeon Park [email protected]