Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onTimechange issue #914

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

onTimechange issue #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ecee54
onTimechangeIssue
amanjr09-glitch Aug 25, 2023
ff9490f
CHANGELOG
amanjr09-glitch Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,12 @@ Plenty of bugfixes, tests and new demos in these 0.14 patch releases.
* Fix demo for IE11 #44 by @lucidlemon
* Package a .css file, not a .scss file as previously done. @mariusandra



### fix
* Fixed the isInteractingwithItem and is now working fine


[0.9.0]: https://github.com/namespace-ee/react-calendar-timeline/compare/v0.8.6...v0.9.0
[0.10.0]: https://github.com/namespace-ee/react-calendar-timeline/compare/v0.9.0...v0.10.0
[0.10.1]: https://github.com/namespace-ee/react-calendar-timeline/compare/v0.10.0...v0.10.1
Expand Down
3 changes: 2 additions & 1 deletion src/lib/Timeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,14 +967,15 @@ export default class ReactCalendarTimeline extends Component {
visibleTimeEnd,
canvasTimeStart,
canvasTimeEnd
selectedItem
} = this.state
let { dimensionItems, height, groupHeights, groupTops } = this.state

const zoom = visibleTimeEnd - visibleTimeStart
const canvasWidth = getCanvasWidth(width, buffer)
const minUnit = getMinUnit(zoom, width, timeSteps)

const isInteractingWithItem = !!draggingItem || !!resizingItem
const isInteractingWithItem = !!draggingItem || !!resizingItem || !!selectedItem

if (isInteractingWithItem) {
const stackResults = stackTimelineItems(
Expand Down