Change NFD's CS replacement policy to LRU #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default was changed over 6 years ago named-data/NFD@32e7609
Pesa
commented
Oct 25, 2024
| @@ -61,13 +56,13 @@ face_system | |||
|
|
|||
| udp | |||
| { | |||
| listen yes | |||
There was a problem hiding this comment.
This is just for consistency with the other config sections that have this explicitly set (even though it's the default).
Pesa
commented
Oct 25, 2024
| port {{udp_port}} | ||
| enable_v4 yes | ||
| enable_v6 yes | ||
|
|
||
| idle_timeout 600 | ||
| unicast_mtu 1452 | ||
| keep_alive_interval 25 |
There was a problem hiding this comment.
This is nonfunctional, it was never implemented in NFD. The config file parser still accepts it for some reason but I'd like to drop it at some point.
|
Any comments? |
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default was changed over 6 years ago (named-data/NFD@32e7609). I guess it never trickled down to the testbed config.
See also: https://redmine.named-data.net/issues/4728