Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overlapping of Images On Home Screen #144

Closed
wants to merge 7 commits into from

Conversation

guy34code
Copy link

Description (required)

Fixes #142 {Use Layout_weight to prevent overlapping of Images On Home Screen}

Screenshots showing what changed (optional - for UI changes)

Before the Changes:

WhatsApp Image 2019-03-26 at 7 57 41 PM

After Changes:

WhatsApp Image 2019-03-26 at 10 38 28 PM


@guy34code
Copy link
Author

@dev-ritik I accidently commit the changes to fix #143 under the same pull request.
I'm new to open source and don't know much, Is there any way to create new pull request now for issue #143 ?

@dev-ritik
Copy link
Collaborator

@guy34code I would suggest you to create a new branch for #143
On the new branch, drop the commits of #142 while u rebase it.
Make a new pull request for it.
On the existing branch, make a hard reset to the extra commits.
Force push the existing branch to update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Layout_weight to prevent overlapping of Images On Home Screen
3 participants