Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.Check for NFD app at the startup 2. RecyclerView for ViewFriendsActivity and SelectRecipientsActivity 3. Positive & Negative Buttons for alertDialog in requestCode = FILE_SELECT_REQUEST_CODE. #109

Closed
wants to merge 3 commits into from

Conversation

AshwinChandlapur
Copy link
Contributor

Check if NDN Forwarding Daemon is installed.
If installed -> Continue Regular Onboarding
If not installed -> Show a Toast Message and request User to install NDN

@jrandallclark jrandallclark self-requested a review March 12, 2019 19:59
@AshwinChandlapur
Copy link
Contributor Author

This commit adds recyclerView to load friendsList in ViewFriendsActivity and SelectRecipientsActivity.

In ViewFriendsActivity, All friends are displayed in recyclerView. If no friend exist, then a toast message "You haven't added any friends" is displayed. As of now, onClick of FriendName a Toast is displayed which can be further extended to ideas like linking to a different page where user will be able to view Friend's profile or remove him/her from FriendsList.

In SelectRecipientsActivity, multi-select OnClick is implemented, user can select multiple friends and share the photo with them. If no friend is selected, the SEND button is not visible. For it to be visible, user should select at-least one friend. If no friend exist, then a toast message "You haven't added any friends" is displayed.

@AshwinChandlapur AshwinChandlapur changed the title Check for NFD app at the startup. Check for NFD app at the startup And RecyclerView for ViewFriendsActivity and SelectRecipientsActivity Mar 13, 2019
@somenath1435
Copy link
Contributor

@AshwinChandlapur squash the commits

@AshwinChandlapur AshwinChandlapur changed the title Check for NFD app at the startup And RecyclerView for ViewFriendsActivity and SelectRecipientsActivity 1.Check for NFD app at the startupRecyclerView for ViewFriendsActivity and SelectRecipientsActivity Mar 14, 2019
@AshwinChandlapur AshwinChandlapur changed the title 1.Check for NFD app at the startupRecyclerView for ViewFriendsActivity and SelectRecipientsActivity 1.Check for NFD app at the startup 2. RecyclerView for ViewFriendsActivity and SelectRecipientsActivity 3. Positive & Negative Buttons for alertDialog in requestCode = FILE_SELECT_REQUEST_CODE. Mar 14, 2019
@AshwinChandlapur
Copy link
Contributor Author

AshwinChandlapur commented Mar 14, 2019

Hi @jrandallclark , I have added one more commit for the issue #124. The code adds 2 buttons for the alertDialog.
Positive-> ShareFiles->OnClick-> Passes the path of selectedFile to SelectRecipientsActivity
Negative-> Cancel-> Dismisses Alert Dialog

Tested on Moto-g6 Play.

…ECT_REQUEST_CODE.

Positive Button is set to Share Files
Negative Button is set to dismiss alert Dialog.
@jrandallclark
Copy link
Contributor

@AshwinChandlapur Why did you close this?

@AshwinChandlapur
Copy link
Contributor Author

AshwinChandlapur commented Mar 15, 2019

I opened Individual Pull Request for each task. I felt submitting all tasks in a single PR would make things clumsy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants