Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rotation when generating lexicon #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

minhphd
Copy link

@minhphd minhphd commented Feb 28, 2023

  • added rotation and generated new lexicon file
  • created a lexicon to csv converter script for reading and debugging lexicon file
  • tested new lexicon file with test1.py

@nalmadi
Copy link
Owner

nalmadi commented Aug 20, 2023

Nice work @minhphd, thanks for making a contribution to this project. Here are a few comments that I have:

It seems like you are taking the average congruence of all rotations, which makes most values around 0.5. Can you change that to the maximum value, as suggested by the methods section of this paper (2nd paragraph):

https://journals.sagepub.com/doi/pdf/10.2466/pms.1968.26.2.659?casa_token=9pbqnl1kFmkAAAAA:T6g-w7b6tVKhN4n40PAAOJKH8tG32Oa7kjQUfGyWxwjd23o30gpaHvponoFpruwQUB79VuSRzuCs

In the same paper you can find a table of letter congruence, it would be great if you can compare the values in the tables to your generated values. They don't have to match perfectly, but they should be correlated.

I will accept the PR with the updates above. Feel free to send me a nudge if you want me to take a look at this. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants