Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 1 vulnerabilities #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naiba4
Copy link
Owner

@naiba4 naiba4 commented Dec 1, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • demo/webpack/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 125/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 0, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.08, Score Version: V5
Missing Release of Resource after Effective Lifetime
SNYK-JS-INFLIGHT-6095116
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: webpack The new version differs by 250 commits.
  • f2f998b 5.1.1
  • bcd6190 Merge pull request #11704 from webpack/bugfix/delete-asset
  • 11935a9 Merge pull request #11703 from webpack/bugfix/11678
  • 63ba54c update chunk to files mapping when deleting assets
  • 4669600 Merge pull request #11690 from webpack/bugfix/11673
  • 234373e Merge pull request #11702 from webpack/deps/terser
  • b6bc273 fix infinite loop in inner graph optimization
  • 50c3a83 fix unused modules in chunk when optimizing runtime-specific
  • 5d9d9b9 fix runtime-specific handling in concatenated modules
  • 250e37c add test case
  • 7925652 upgrade terser-webpack-plugin
  • 27796db Merge pull request #11669 from webpack/dependabot/npm_and_yarn/ts-loader-8.0.5
  • bd5aab8 Merge pull request #11692 from webpack/dependabot/npm_and_yarn/babel/core-7.12.0
  • 886bbd5 Merge pull request #11693 from webpack/dependabot/npm_and_yarn/react-dom-16.14.0
  • 3a14b3d Merge pull request #11694 from webpack/dependabot/npm_and_yarn/react-16.14.0
  • ddf9936 chore(deps-dev): bump react from 16.13.1 to 16.14.0
  • dc6e69a chore(deps-dev): bump react-dom from 16.13.1 to 16.14.0
  • 8f18de9 chore(deps-dev): bump @ babel/core from 7.11.6 to 7.12.0
  • c0410e8 Merge pull request #11686 from webpack/bugfix/11677
  • 4504046 order runtime chunks correctly when they depend on each other
  • 74a44cd add comment to help tagging for the bot
  • e97efb7 chore(deps-dev): bump ts-loader from 8.0.4 to 8.0.5
  • 77329b4 5.1.0
  • 48c10f3 Merge pull request #11653 from log2-hwan/fix-moduletemplate-deprecation

See the full diff

Package name: webpack-cli The new version differs by 6 commits.

See the full diff

Package name: webpack-dev-server The new version differs by 250 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
webpack-cli 2.1.5...3.3.12 shell +4/-378 254 kB evilebottnawi
webpack-dev-server 3.11.3...4.15.1 network, shell +57/-68 4.2 MB evilebottnawi

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Chronological version anomaly schema-utils 4.2.0
Environment variable access schema-utils 4.2.0
Chronological version anomaly p-retry 4.6.2
Chronological version anomaly @types/mime 1.3.5
Chronological version anomaly webpack-cli 3.3.12
Dynamic require webpack-cli 3.3.12
Environment variable access webpack-cli 3.3.12
New author webpack-cli 3.3.12
Shell access webpack-cli 3.3.12
Deprecated memfs 3.6.0
  • Reason: this will be v4
Dynamic require webpack-dev-server 4.15.1
Environment variable access webpack-dev-server 4.15.1
Network access webpack-dev-server 4.15.1
Environment variable access launch-editor 2.6.1
No README launch-editor 2.6.1
Shell access launch-editor 2.6.1
Environment variable access global-modules 2.0.0
Environment variable access picocolors 1.0.0
Unmaintained picocolors 1.0.0
  • Last Publish: 10/13/2021, 2:48:42 AM
Major refactor @leichtgewicht/ip-codec 2.0.4
  • Change Percentage: 97.87
  • Current Line Count: 431
  • Previous Line Count: 461
  • Lines Changed: 873
Unmaintained @leichtgewicht/ip-codec 2.0.4
  • Last Publish: 5/9/2022, 4:58:42 PM
Mixed license which 1.3.1
Network access bonjour-service 1.1.1
No v1 @types/retry 0.12.0
No v1 @types/send 0.17.4
No v1 @types/sockjs 0.3.36
Unmaintained define-lazy-prop 2.0.0
  • Last Publish: 4/14/2021, 7:54:05 AM
Unmaintained is-docker 2.2.1
  • Last Publish: 8/31/2021, 11:02:35 PM
Unmaintained detect-file 1.0.0
  • Last Publish: 8/6/2017, 3:09:20 AM
Unmaintained ajv-formats 2.1.1
  • Last Publish: 11/7/2021, 7:08:56 PM
Unmaintained findup-sync 3.0.0
  • Last Publish: 10/31/2021, 9:02:15 PM

Next steps

What is a chronological version anomaly?

Semantic versions published out of chronological order.

This could either indicate dependency confusion or a patched vulnerability.

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

What is dynamic require?

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Why are READMEs important?

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

What are unmaintained packages?

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

What is a major refactor?

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Consider waiting before upgrading to see if any issues are discovered, or be prepared to scrutinize any bugs or subtle changes the major refactor may bring. Publishers my consider publishing beta versions of major refactors to limit disruption to parties interested in the new changes.

What is a mixed license?

(Experimental) Package contains multiple licenses.

A new version of the package should be published that includes a single license. Consumers may seek clarification from the package author. Ensure that the license details are consistent across the LICENSE file, package.json license field and license details mentioned in the README.

What is wrong with semver < v1?

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

If the package sees any general use, it should begin releasing at version 1.0.0 or later to benefit from semver.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants