Skip to content

Commit

Permalink
Deflake Dual channel replication test batch
Browse files Browse the repository at this point in the history
Deflaked the following tests:
1. dual-channel-replication with multiple replicas
2. Test diverse replica sync: dual-channel on/off
3. Test replica's buffer limit reached
4. dual-channel-replication fails when primary diskless disabled

First check that replica is online and then wait for value to propegate.

test failed in
https://github.com/valkey-io/valkey/actions/runs/9986538309/job/27599242506

Signed-off-by: naglera <[email protected]>
  • Loading branch information
naglera committed Jul 18, 2024
1 parent 4bd8d70 commit 95a275e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions tests/integration/dual-channel-replication.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,12 @@ start_server {tags {"dual-channel-replication external:skip"}} {
assert {[s -2 replicas_replication_buffer_size] <= 16385*2}

# Wait for sync to succeed
wait_for_value_to_propegate_to_replica $primary $replica1 "key4"
wait_for_condition 50 1000 {
[status $replica1 master_link_status] == "up"
} else {
fail "Replica is not synced"
}
wait_for_value_to_propegate_to_replica $primary $replica1 "key4"
}

$replica1 replicaof no one
Expand Down Expand Up @@ -1107,7 +1107,5 @@ start_server {tags {"dual-channel-replication external:skip"}} {
fail "Replica offset didn't catch up with the primary after too long time"
}
}


}
}
}

0 comments on commit 95a275e

Please sign in to comment.