Minor fix for --loops option in normal testing framework (valkey-io#781)

Inputing a negative number equivalent to --loop, and inputing a number greater than or equal to 0 will cause the tests to be run one more time. Signed-off-by: Binbin <[email protected]>
naglera · Jul 13, 2024 · 8c92b2f · 8c92b2f
1 parent a4ee8da
commit 8c92b2f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/tests/test_helper.tcl b/tests/test_helper.tcl
@@ -475,7 +475,7 @@ proc signal_idle_client fd {
         send_data_packet $fd run [lindex $::all_tests $::next_test]
         lappend ::active_clients $fd
         incr ::next_test
-        if {$::loop && $::next_test == [llength $::all_tests]} {
+        if {$::loop > 1 && $::next_test == [llength $::all_tests]} {
             set ::next_test 0
             incr ::loop -1
         }
@@ -703,6 +703,10 @@ for {set j 0} {$j < [llength $argv]} {incr j} {
         set ::loop 2147483647
     } elseif {$opt eq {--loops}} {
         set ::loop $arg
+        if {$::loop <= 0} {
+            puts "Wrong argument: $opt, loops should be greater than 0"
+            exit 1
+        }
         incr j
     } elseif {$opt eq {--timeout}} {
         set ::timeout $arg