Fix race condition in rdb client free

Signed-off-by: Ubuntu <[email protected]>
naglera · Jul 23, 2024 · 7cd8c5e · 7cd8c5e
1 parent c75d2dd
commit 7cd8c5e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/networking.c b/src/networking.c
@@ -4332,9 +4332,9 @@ int closeClientOnOutputBufferLimitReached(client *c, int async) {
     if (checkClientOutputBufferLimits(c)) {
         sds client = catClientInfoString(sdsempty(), c);
         /* Remove RDB connection protection on COB overrun */
-        c->flag.protected_rdb_channel = 0;
 
-        if (async) {
+        if (async || c->flag.protected_rdb_channel) {
+            c->flag.protected_rdb_channel = 0;
             freeClientAsync(c);
             serverLog(LL_WARNING, "Client %s scheduled to be closed ASAP for overcoming of output buffer limits.",
                       client);