Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue while implementing balloon hashing in javascript using this as a reference.
The issue resolved down to getting different values for
other
, and that was because the python implementation generates a bigint from the entire buffer, rather than reading a 64 bit integer as in the C reference implementation.Note: This commit breaks all the unit tests, so if those test vectors are known good then the code below is a mistake. But if they're not this may be an issue.