This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Bump to react 16. #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to successfully install and use it in my own respository by manually pushing the dist directory (since I was installing this package from my fork's git URL, the prepublish script doesn't ever get run). I've removed the dist folder in the final diff though :) - Bump to react@16 and react-dom@16 - Bump react/react-dom TS types to ^16 - Fix snapshots to reflect react 16
This was referenced Jan 15, 2018
|
Looking good @ayc92 but tests not passing. Mind to check it out? I'll gladly merge after that. |
styled-components@^2.4.0 now requires stylis@^3.4.0, which updates some of the flexbox vendor prefixes
|
@nachoaIvarez I fixed the snapshot tests to reflect the stylis version upgrade. It patches some of the flexbox prefixing to support IE10. |
|
I have some issues with TS definitions when trying to use the library with React 16. I think they could be solved by this PR. |
|
@nachoaIvarez Is there an ETA for merging this? I just updated to React 16 and this is now happening which I think is solved by this PR. (3636,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'a' must be of type 'DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>', but here has type 'DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>'.``` |
|
Forked, merged and published as @g07cha/flexbox-react if anyone needs it. |
|
@G07cha thanks, hope this PR will get merged soon. Till then i will use your version. :) |
|
I could really use this update |
|
@nachoaIvarez are you ok to merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to successfully install and use it in my own respository by manually pushing the dist directory (since I was installing this package from my fork's git URL, the prepublish script doesn't ever get run). I've removed the dist folder in the final diff though :)