Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL in client examples #44

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fix URL in client examples #44

merged 2 commits into from
Apr 9, 2024

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Mar 31, 2024

- Change URL in client examples from http://fiikus.net/asciiart/pizza.txt to  http://artscene.textfiles.com/asciiart/texthistory.txt
- Found DNS example was using channel 30 by default, revert back to default channel
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Click here for the full clang-format patch
diff --git a/examples/Getting_Started_SimpleClient_Mesh_DNS/Getting_Started_SimpleClient_Mesh_DNS.ino b/examples/Getting_Started_SimpleClient_Mesh_DNS/Getting_Started_SimpleClient_Mesh_DNS.ino
index 6df45e6..06c6565 100644
--- a/examples/Getting_Started_SimpleClient_Mesh_DNS/Getting_Started_SimpleClient_Mesh_DNS.ino
+++ b/examples/Getting_Started_SimpleClient_Mesh_DNS/Getting_Started_SimpleClient_Mesh_DNS.ino
@@ -33 +33 @@ char icewind[] = { "109.120.203.163" };  //http://109.120.203.163/web/blyad.club
-char ascii[] = { "artscene.textfiles.com" };     //http://artscene.textfiles.com/asciiart/texthistory.txt
+char ascii[] = { "artscene.textfiles.com" };  //http://artscene.textfiles.com/asciiart/texthistory.txt

Have any feedback or feature suggestions? Share it here.

…_SimpleClient_Mesh_DNS.ino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review March 31, 2024 06:07

outdated suggestion

@2bndy5 2bndy5 linked an issue Mar 31, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Mar 31, 2024

Memory usage change @ f32e377

Board flash % RAM for global variables %
arduino:avr:nano 🔺 0 - +58 0.0 - +0.19 🔺 0 - +38 0.0 - +1.86
arduino:samd:mkrzero 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Getting_Started_SimpleClient_Mesh
flash
% examples/Getting_Started_SimpleClient_Mesh
RAM for global variables
% examples/Getting_Started_SimpleServer_Mesh
flash
% examples/Getting_Started_SimpleServer_Mesh
RAM for global variables
% examples/InteractiveServer_Mesh
flash
% examples/InteractiveServer_Mesh
RAM for global variables
% examples/MQTT/mqtt_basic
flash
% examples/MQTT/mqtt_basic
RAM for global variables
% examples/MQTT/mqtt_basic_2
flash
% examples/MQTT/mqtt_basic_2
RAM for global variables
% examples/SimpleClient_Mesh
flash
% examples/SimpleClient_Mesh
RAM for global variables
%
arduino:avr:nano 38 0.12 38 1.86 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 58 0.19 34 1.66
arduino:samd:mkrzero 40 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 12 0.0 0 0.0
Click for full report CSV
Board,examples/Getting_Started_SimpleClient_Mesh<br>flash,%,examples/Getting_Started_SimpleClient_Mesh<br>RAM for global variables,%,examples/Getting_Started_SimpleServer_Mesh<br>flash,%,examples/Getting_Started_SimpleServer_Mesh<br>RAM for global variables,%,examples/InteractiveServer_Mesh<br>flash,%,examples/InteractiveServer_Mesh<br>RAM for global variables,%,examples/MQTT/mqtt_basic<br>flash,%,examples/MQTT/mqtt_basic<br>RAM for global variables,%,examples/MQTT/mqtt_basic_2<br>flash,%,examples/MQTT/mqtt_basic_2<br>RAM for global variables,%,examples/SimpleClient_Mesh<br>flash,%,examples/SimpleClient_Mesh<br>RAM for global variables,%
arduino:avr:nano,38,0.12,38,1.86,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,58,0.19,34,1.66
arduino:samd:mkrzero,40,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,12,0.0,0,0.0

@TMRh20 TMRh20 merged commit 16f7cd1 into master Apr 9, 2024
61 checks passed
@2bndy5 2bndy5 deleted the FixURL branch June 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main URL in client examples is no longer valid
1 participant