-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNORE UPPERCASE OPENSTACK TOO FOR FUCKS SAKE #5
base: master
Are you sure you want to change the base?
Conversation
OBVIOUSLY you don't want jstir bothering you every time you mention an `OPENSTACK_*` environment variable. Jesus.
You are missing a comma after "TOO" in the commit message. Also "FUCKS" should be "FUCK'S". Otherwise LGTM. |
If you're trying to not trigger on Alternatively, if you are prone to RANDOM ALL-CAPS OUTBURSTS ABOUT OPENSTACK (and honestly, who isn't?), I think this is 👍, though I agree with @infraredgirl on needing an apostrophe on FUCKS. |
💩 |
I concur with jsomara. |
/me subscribes to notifications from this PR 🐨 |
I googled the emojis and made you folks a steeplechase diorama🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🎎 🏇 🚴 🐎 🏃 🐩 |
-1 I do want jstir bother me every time someone mentions an OPENSTACK_* environment variable. Jesus. |
You are my hero, @jistr 👏 |
☁️ |
-1 this doesn't pass PEP8 |
@jsomara awesoooome 😍 |
Only you can prevent forest fires, @jsomara 🐻 |
OBVIOUSLY you don't want jstir bothering you every time you mention an
OPENSTACK_*
environment variable. Jesus.