fix(iroh-sync): prevent panic in namespace migration #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Nov 7, 2023
Frando
force-pushed
the
fix-migration-namespaces
branch
from
d71edad to
aa23786
Compare
| Ok(MigrateOutcome::Execute(entries)) | ||
| } | ||
|
|
||
| /// Delete the v1 namespaces table. | ||
| fn migration_003_namespaces_delete_v1(tx: &WriteTransaction) -> Result<MigrateOutcome> { |
There was a problem hiding this comment.
can you add a comment why this is its own migration? this is quite surprising
There was a problem hiding this comment.
👍 added a commit with a comment
dignifiedquire
approved these changes
Nov 7, 2023
Frando
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The migration as commited with #1770 panics when starting iroh with an existing data dir. The reason is that redb panics when deleting table in a transaction where they were opened as well. See: cberner/redb#715
This fixes this by moving the table deletion to a separate transaction.
The limitation and potential panic in redb was fixed in cberner/redb#716 so once we upgrade to the next (still unreleased) version of redb, this can be removed again.
Change checklist