-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ZeroMQ 5.2.4 - fix build on Electron 9 #32
Conversation
"5" and "^5" are equivalent. See https://semver.npmjs.com/ if you want to play with different combinations. I don't find '^' and '~` readable. |
@n-riesco I updated the PR to use the fixed ZeroMQ. I will release Hydrogen by a link to my GitHub branch for now until you merge this. |
I see in https://www.npmjs.com/package/zeromq?activeTab=versions that [email protected] has already been released. |
I updated ZeroMQ. This PR now includes the working ZeroMQ 5. |
I'm sorry I wasn't clear before. This PR is not really necessary.
The purpose of semver is exactly that (otherwise every time a dependency made a new release would trigger a cascade of releases in the depedants).
|
I am not a fan of using |
Releasing a new version wouldn't just be informing downstream. |
@aminya |
Fixes #31