fix(scraper): calling method on promise

mytlogos · Sep 5, 2022 · 9c436a0 · 9c436a0
1 parent 222af51
commit 9c436a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/core/src/logger.ts b/packages/core/src/logger.ts
@@ -88,7 +88,7 @@ const logger = winston.createLogger({
         formatLogFmt(),
         // use logfmt here too
         format.printf((info) => {
-          return `${info.timestamp + ""} ${info.level}: ${info.message}`;
+          return `${info.timestamp + ""} ${info.level}: ${info.message + ""}`;
         }),
       ),
     }),

diff --git a/packages/scraper/src/externals/request/request.ts b/packages/scraper/src/externals/request/request.ts
@@ -45,10 +45,12 @@ function transformAxiosResponse(response: AxiosResponse): Response {
 const pages = new Cache<string, Promise<Page>>({ stdTTL: 60 * 10, useClones: false, size: 20 });
 const pageUsed = new Set<string>();
 
-pages.on("expired", (_key, value: Page) => {
-  if (!value.isClosed()) {
-    value.close();
-  }
+pages.on("expired", (_key, value: Promise<Page>) => {
+  value.then((page) => {
+    if (!page.isClosed()) {
+      page.close();
+    }
+  });
 });
 
 // Modified from https://www.bannerbear.com/blog/ways-to-speed-up-puppeteer-screenshots/