rm CastOutputToFloat when finetuning #81
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CastOutputToFloat
seems unnecessary when finetuning. When computing loss, the codelm_logits = lm_logits.to(torch.float32)
will cast half to float32. I also compare the result w/wo theCastOutputToFloat
op and run finetuning two times, the loss curves are similar(I only test with first 500 steps with a small proportion of data from alpaca.json).With
CastOutputToFloat
:2nd run:
Without
CastOutputToFloat
: 16.4G1st run:
2nd run: