fix(plugins): improve logging (#190)

mykso · Dec 26, 2023 · ba31a3b · ba31a3b
1 parent e9fe05e
commit ba31a3b
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 10 deletions.
diff --git a/cmd/root.go b/cmd/root.go
@@ -28,6 +28,7 @@ var (
 
 func NewMyksCmd(version, commit, date string) *cobra.Command {
 	cobra.OnInitialize(initLogger)
+	zerolog.SetGlobalLevel(zerolog.InfoLevel)
 	cmd := newRootCmd(version, commit, date)
 	cmd.AddCommand(allCmd)
 	cmd.AddCommand(renderCmd)

diff --git a/cmd/smart-mode.go b/cmd/smart-mode.go
@@ -6,11 +6,12 @@ import (
 	"os"
 	"strings"
 
-	"github.com/logrusorgru/aurora/v4"
-	"github.com/mykso/myks/internal/myks"
+	aurora "github.com/logrusorgru/aurora/v4"
 	"github.com/rs/zerolog/log"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
+
+	"github.com/mykso/myks/internal/myks"
 )
 
 const (

diff --git a/internal/myks/plugins.go b/internal/myks/plugins.go
@@ -2,6 +2,7 @@ package myks
 
 import (
 	"bytes"
+	"fmt"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -96,7 +97,7 @@ func (p PluginCmd) Name() string {
 }
 
 func (p PluginCmd) Exec(a *Application, args []string) error {
-	step := "Plugin " + p.Name()
+	step := p.Name()
 	log.Trace().Msg(a.Msg(step, "execution started"))
 
 	env, err := p.generateEnv(a)
@@ -114,16 +115,28 @@ func (p PluginCmd) Exec(a *Application, args []string) error {
 	// log env
 	log.Debug().Msg(a.Msg(step, msgRunCmd("", p.cmd, args)))
 	err = cmd.Run()
+	allOutput := stderrBs.String() + stdoutBs.String()
 	if err != nil {
 		log.Error().Msg(msgRunCmd("Failed on step: "+step, p.cmd, args))
-		log.Error().Err(err).
-			Str("stdout", stdoutBs.String()).
-			// writing std error into message to avoid wrapping
-			Msg(a.Msg(step, "Plugin execution failed: "+stderrBs.String()))
+		if allOutput != "" {
+			log.Error().Err(err).
+				// writing std error into message to avoid wrapping
+				Msg(a.Msg(step, fmt.Sprintf("Plugin execution failed:\n\n%s", allOutput)))
+		} else {
+			log.Error().Err(err).
+				// writing std error into message to avoid wrapping
+				Msg(a.Msg(step, "Plugin execution failed"))
+		}
 	} else {
-		log.Info().
-			// writing std out into message to avoid wrapping
-			Msg(a.Msg(step, "Plugin execution succeeded: "+stdoutBs.String()))
+		if allOutput != "" {
+			log.Info().
+				// writing std out into message to avoid wrapping
+				Msg(a.Msg(step, fmt.Sprintf("Plugin execution succeeded:\n\n%s", allOutput)))
+		} else {
+			log.Info().
+				// writing std out into message to avoid wrapping
+				Msg(a.Msg(step, "Plugin execution succeeded."))
+		}
 	}
 	return err
 }