Introduce live message sending for EBT sessions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing EBT I noticed that Manyverse sends messages of interest to active session peers immediately, instead of sending a partial vector clock indicating the update. This PR introduces that same behaviour to solar.
An event is emitted when the local key-value store is updated with a new message. The event includes the feed ID and the sequence number of the appended message. Those details are matched on in the EBT manager. If we have an active session with a peer interested in receiving messages from that feed, we send the message (as long as the sequence number is greater than the sequence number in the latest vector clock from that peer).
Live updates are now bidirectional when an EBT session is active between solar and Manyverse, as well as between two instances of solar.