Match on vector clock response and use negative request numbers #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces deserialization code for vector clocks in MUXRPC responses, which had previously been erroneously considered redundant and removed, and uses negative request numbers in EBT-related MUXRPC responses.
Bidirectional replication is now working; tested between solar and Manyverse, and solar and Patchwork.
Note that live outbound updates from solar are not yet working. In other words, if you have an active EBT session and the local store of solar is updated - new messages of interest are not automatically sent out to connected peers. Instead, only a partial vector clock is sent. I am going to work on the live message sending next.
CC: @black-puppydog