Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 manage multiple sessions with user auth #16

Merged

Conversation

antolinos
Copy link
Contributor

@antolinos antolinos commented Dec 11, 2024

The following list should now been populated with the shared sessions thanks to the emit done at AbstractLIMS
image

@antolinos antolinos linked an issue Dec 11, 2024 that may be closed by this pull request
@marcus-oscarsson
Copy link
Member

Thanks !

@axelboc
Copy link
Contributor

axelboc commented Dec 11, 2024

Might be worth pulling upstream changes before merging (i.e. functional component).

@marcus-oscarsson
Copy link
Member

@axelboc and @antolinos, my apologies I managed to loose a PR from Axel two weeks ago. That was why I was a bit surprised yesterday @antolinos, (and was looking for things that I could not find).

I reopened the PR on mxcubeweb and then Ill rebase and take the necessary commits from this PR.

Again really sorry for the confusion, thanks for the PR's

@antolinos
Copy link
Contributor Author

@marcus-oscarsson No problemo!
@axelboc Please, if you have the chance, do not hesitate to review this. Because I'm not using state and props for a long time I admit that I have forgotten how they work together. So, I am pretty sure there is room for improvement. The feature was that we need to refresh the list of sessions for the user A when a user B logs in with the sessions that A and B share. Thanks!

@marcus-oscarsson marcus-oscarsson force-pushed the 14-manage-multiple-sessions-with-user-auth branch from 9b21b20 to e8d3ce5 Compare December 11, 2024 14:24
@marcus-oscarsson
Copy link
Member

Alright, so I thinks what @axelboc did already solves the problem, as you can see on:

proposalList.find((s) => s.session_id === selectedProposalID),

So proposalList comes from the right place and should then be updated accordingly.

It only leaves out the commit the removes the user from the internal LIMS structures when we logout. If that makes sense.

@marcus-oscarsson
Copy link
Member

Thanks again, and my apologies for my clumsiness :/

@marcus-oscarsson marcus-oscarsson merged commit f0ecc14 into esrf-develop Dec 11, 2024
14 checks passed
@marcus-oscarsson marcus-oscarsson deleted the 14-manage-multiple-sessions-with-user-auth branch December 11, 2024 14:42
@axelboc
Copy link
Contributor

axelboc commented Dec 11, 2024

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage multiple sessions with user auth
3 participants