Refactor Schema class, plus some other fix ups
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* _local_schema_helper -> default_schema_helper * _lsst_schema_helper -> lsst_schema_helper
troyraen
changed the title
Schema into dedicated module, plus some fix upsSchema class, plus some other fix ups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
schema.Schemathat are specific to different serialization formats.Fixed
Changed
exceptions.SchemaNotFoundError->exceptions.SchemaError, repurposed for more general use.Removed
exceptions.OpenAlertError. Useexceptions.SchemaErrorinstead.lsst-alert-packetpackage. We cannot install this from a git repo and also publish our package to PyPI. Need to figure out how to fix this. Without it, 'schema.SchemaHelper.lsst_auto_schema_helper' will not work.