Djperrefort/compare ew #16

djperrefort · 2019-07-31T12:03:10Z

This PR introduces preliminary pseudo equivalent width calculations. Values are calculated both by fixing the feature boundaries to those determined by the observed spectrum and also by determining the feature boundaries for each observed/modeled spectrum individually.

Changes include:

Adds tabulated equivilent width calculations to results/equivalent_width
Extends the CLI to include the equivalent_width subparser
Adds the run_analysis.sh script for executing all analysis tasks.
Moves some logic out of lc_colors module and into utils. Most natably the get_csp_t0 and get_csp_ebv functions.
Updates notebooks to reflect UI changes.

This PR makes partial progress on Issue #7

djperrefort added 22 commits July 24, 2019 13:42

Outlines functions for tabulating EW values

3b36edc

Fills in logical place holders

39ac442

Adds handeling of unobserved features when tabulating ew

1a83a72

Adds EW results table to notebook

28dcd21

Outlines logic for EW interpolation

b1f7530

Fixes algebra error

ae85619

Adds test for calc_ew function

a84b219

Merges in changes from master

2cc0260

Moves feature definitions into a yaml file

152c549

Adds option to fix / not fix feature boundaries

e81495f

Sets model extinction values before pew calculation

f4a939f

Updates CLI

0a634c4

Fixes bug in CLI parsing

1ba015a

Starts adding tests

020b164

Adds some tests to Tabulation class

23649f2

Docstring edits

e67d0f6

Adds place holder test for pew interpolation

af85562

Makes test_create_pew_table stricter

5e6a4b7

Ensures all targets are in ew output tables

21c879d

Upgrades to sndata 0.5.0

ebceabc

Fixes tabulation error

615a8c4

Updates notebooks to reflect analysis UI changes

0477747

djperrefort self-assigned this Jul 31, 2019

djperrefort requested a review from ojwg July 31, 2019 12:04

djperrefort added the Analysis Scientific analysis label Jul 31, 2019

Adds travis.yml

d281bae

djperrefort force-pushed the djperrefort/compare_ew branch from ac9cbe8 to d281bae Compare July 31, 2019 12:18

djperrefort added 2 commits July 31, 2019 08:18

Adds eigen to travis install

121bf0b

Removes eigen and kernel from install

a660b69

djperrefort added 14 commits July 31, 2019 08:33

fixes typo in yaml pip name

db9d542

equivalent_width.py -> test_equivalent_width.py

d77a31e

Registers CSP DR3 filters in tests

baa46e1

Adds setup file

049251c

Fixes failing test_continuum_func

5a44404

Removes python 3.6 from tests

833429b

Adds package data to setup.py

93ebbd4

Fixes failing test_double_peak

1997658

Adds model files to package requirements

6e4f7ec

Fixes failing test_calc_ew

2ef9737

Ensures DR3 data is available for testing

9d74117

Fixes all failing tests

621c5c2

Updates EW results table

1c2147e

Adds peak model pew to pipeline outputs

e493605

djperrefort force-pushed the djperrefort/compare_ew branch from d6824d1 to e493605 Compare July 31, 2019 18:10

djperrefort added 2 commits July 31, 2019 16:00

Updates ew notebook with new plot

4e02bc8

Minor organization edits

d575ae9

djperrefort added a commit that referenced this pull request Aug 1, 2019

Merge pull request #16 from djperrefort/compare_ew

19ab859

djperrefort merged commit a178804 into master Aug 1, 2019

djperrefort deleted the djperrefort/compare_ew branch August 1, 2019 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Djperrefort/compare ew #16

Djperrefort/compare ew #16

djperrefort commented Jul 31, 2019 •

edited

Loading

Djperrefort/compare ew #16

Djperrefort/compare ew #16

Conversation

djperrefort commented Jul 31, 2019 • edited Loading

djperrefort commented Jul 31, 2019 •

edited

Loading