Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and Go version #83

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

tklauser
Copy link
Contributor

Currently, unparam panics in the presence of range-over-func constructs:

panic: Cannot range over: func(yield func(KV, uint64) bool)

Bump golang.org/x/tools to latest and Go to 1.23 to support range-over-func.

Running `go get golang.org/x/tools@latest` to bump that version which
also bumps the required Go version.
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser
Copy link
Contributor Author

@mvdan Would you mind merging this please?

@mvdan
Copy link
Owner

mvdan commented Sep 17, 2024

Ah thanks for the ping. I kicked off CI then got sidetracked while waiting.

@mvdan mvdan merged commit 57a3b42 into mvdan:master Sep 17, 2024
6 checks passed
@tklauser tklauser deleted the bump-dependencies-and-go branch September 17, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants