add MS sample data + new DAA field #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡ REFACTOR: rename data3 to UsdlDataTN
chancesmith
commented
Dec 7, 2021
Comment on lines
+3
to
+4
| const UsdlDataTN = require('./sample/index').UsdlDataTN | ||
| const UsdlDataMS = require('./sample/index').UsdlDataMS |
There was a problem hiding this comment.
rename data by state
chancesmith
commented
Dec 7, 2021
Comment on lines
+20
to
+23
| expect(parsedData.documentNumber).toEqual('802926467') | ||
| expect(parsedData.firstName).toEqual('JANICE') | ||
| expect(parsedData.lastName).toEqual('SMITH') | ||
| expect(parsedData.middleName).toEqual('C') |
There was a problem hiding this comment.
parse full name into separate fields
chancesmith
commented
Dec 7, 2021
| @@ -5,6 +5,7 @@ exports.CodeToKey = { | |||
| DCB: 'jurisdictionRestrictionCodes', | |||
| DCD: 'jurisdictionEndorsementCodes', | |||
| DBA: 'dateOfExpiry', | |||
| DAA: 'fullName', | |||
chancesmith
commented
Dec 7, 2021
| let started | ||
| lines.slice(0, -1).forEach((line) => { | ||
| if (!started) { | ||
| if (line.indexOf('ANSI ') === 0) { | ||
| if (line.indexOf('ANSI') === 0) { |
There was a problem hiding this comment.
remove space from ANSI to check for MS when space doesn't exist
chancesmith
commented
Dec 7, 2021
Comment on lines
+42
to
+47
| if (code === 'DAA') { | ||
| const nameArray = value.split(',') | ||
| props.firstName = nameArray[1] | ||
| props.lastName = nameArray[0] | ||
| props.middleName = nameArray[2] | ||
| } |
There was a problem hiding this comment.
past full name to separate fields
|
@chancesmith if you're interested in continuing to work with this repo, can i add you to collaborators? Then you can do your thing. Just please stick to semantic versioning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes made