Error on duplicate enum values

src/builder.js

@@ -342,6 +342,7 @@ build()
                 }
 
                 e.addValue(declaration.id.name, currentValue);
+                model.registerDeclaration(declaration.id.name, declaration);
 
                 declaration.enumValue = currentValue;
 

src/compiler.js

@@ -269,7 +269,7 @@ _runOnCompileCallback(onCompileCallback, ojFile, doneCallback)
         },
 
         getContents: () => {
-            return lines.join("\n");
+            return lines ? lines.join("\n") : ""
         },
 
         getPath: () => {

src/model/OJModel.js

@@ -383,12 +383,13 @@ getAggregateClass()
     return result;
 }
 
-_registerDeclaration(name)
+
+registerDeclaration(name, node)
 {
     let existing = this._declarationMap[name];
 
     if (existing) {
-        Utils.throwError(OJError.DuplicateDeclaration, "Duplicate declaration of '" + name + "'.")
+        Utils.throwError(OJError.DuplicateDeclaration, "Duplicate declaration of '" + name + "'.", node)
     }
 
     this._declarationMap[name] = true;
@@ -400,7 +401,7 @@ addConst(ojConst)
     let name = ojConst.name;
 
     this.consts[name] = ojConst;
-    this._registerDeclaration(name);
+    this.registerDeclaration(name);
 }
 
 
@@ -421,7 +422,8 @@ addEnum(ojEnum)
     }
 
     this.enums[name] = ojEnum;
-    this._registerDeclaration(name);
+
+    this.registerDeclaration(name);
 }
 
 
@@ -448,7 +450,7 @@ addClass(ojClass)
 
     } else {
         this.classes[name] = ojClass;
-        this._registerDeclaration(name);
+        this.registerDeclaration(name);
     }
 }
 
@@ -474,7 +476,7 @@ addType(ojType)
     }
 
     this.types[name] = ojType;
-    this._registerDeclaration(name);
+    this.registerDeclaration(name);
 }
 
 
@@ -483,7 +485,7 @@ addGlobal(ojGlobal)
     let name = ojGlobal.name;
 
     this.globals[name] = ojGlobal;
-    this._registerDeclaration(name);
+    this.registerDeclaration(name);
 }
 
 

src/typechecker/Typechecker.js

@@ -108,6 +108,7 @@ check(model, defs, files, callback)
         let defsKey = ojFile.path + path.sep + defsSuffix;
 
         sourceFileMap[defsKey] = this._getSourceFile(defsKey, ojFile.contents);
+        originalFileMap[defsKey] = ojFile.path;
     });
 
     if (!this._globalDefsSourceFile) {

test/issues/TestIssue112.oj

@@ -15,7 +15,7 @@
 
 function runTests()
 {
-    return [Foo runTest] == 5
+    return [TestIssue112 runTest] == 5
 }
 
 runTests();

test/multi/TestErrors.oj

@@ -290,13 +290,31 @@ function test() {
 @end
 
 
-
 // --------------------------------------------------------------------
-// @name Duplicate Enum
+// @name Duplicate Enum Name
 
 @enum Foo { Foo1, Foo2 }
 @enum Foo { Bar1, Bar2 } //@error OJDuplicateDeclarationError
 
+
+// --------------------------------------------------------------------
+// @name Duplicate Enum Value 1
+
+@enum Foo { Foo1, Foo2 }
+@enum Bar { Foo1, Foo2 } //@error OJDuplicateDeclarationError
+
+
+// --------------------------------------------------------------------
+// @name Duplicate Enum Value 2
+
+@enum { Foo1, FooDuplicate }
+
+@enum {
+    Foo2,
+    FooDuplicate //@error OJDuplicateDeclarationError
+}
+
+
 // --------------------------------------------------------------------
 // @name Circular Class 1
 // @error-no-line OJCircularClassHierarchyError