Add check for meta.json file #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
afeena
reviewed
Mar 3, 2020
bin/snare
Outdated
|
|
||
| This function makes sure none of the path in that is missing the `hash` value. | ||
|
|
||
| refer to issue: https://github.com/mushorg/snare/issues/201 |
afeena
reviewed
Mar 3, 2020
bin/snare
Outdated
| @@ -176,6 +196,11 @@ if __name__ == '__main__': | |||
|
|
|||
| with open(os.path.join(full_page_path, 'meta.json')) as meta: | |||
| meta_info = json.load(meta) | |||
|
|
|||
| if not check_meta_file(meta_info): | |||
| print_color("meta.json is missing some hash values. Please clone the pages again.", "ERROR") | |||
There was a problem hiding this comment.
Is it a good idea to point exact missing values?
afeena
reviewed
Mar 3, 2020
bin/snare
Outdated
| @@ -34,6 +34,26 @@ from snare.utils import snare_helpers | |||
| from snare.utils.snare_helpers import str_to_bool, print_color | |||
|
|
|||
|
|
|||
| def check_meta_file(meta_info): | |||
There was a problem hiding this comment.
Maybe it's better to put it in utils? https://github.com/mushorg/snare/blob/master/snare/utils/snare_helpers.py
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@afeena as you said in this comment I've added a check for the
meta.jsonfile.Let me know if any other changes are required.