Fix #25145: Crash relating to StaffTypeChange
#26289
Open
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
reviewed
Jan 31, 2025
src/engraving/dom/measure.cpp
Outdated
| @@ -3475,6 +3481,21 @@ bool Measure::canAddStringTunings(staff_idx_t staffIdx) const | |||
| return !alreadyHasStringTunings; | |||
| } | |||
|
|
|||
| bool Measure::canAddStaffTypeChange(staff_idx_t staffIdx) const | |||
| { | |||
| for (const EngravingObject* child : scanChildren()) { | |||
There was a problem hiding this comment.
Measure::scanChildren does lots of stuff that we don't need here. I think you can more simply use
for (const EngravingItem* item : m_el)
There was a problem hiding this comment.
Thanks - done!
mathesoncalum
force-pushed
the
25145-stafftype_change_crash
branch
from
d9669e1 to
b7b4fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #25145
This fix is a two-parter:
StaffTypeChangesto be added to measures that already haveStaffTypeChanges(see video for updated behaviour).StaffTypeChangesin existing scores (show corruption message instead of crashing).stcdrag.mov