Created for reviewing the presale app #1
Conversation
general/mrc20_presale.js
Outdated
|
|
||
| let tokenPrice = toBaseUnit(token.price.toString(), 18) | ||
| let finalMaxCap | ||
| if (currentTime < PUBLIC_SALE) { |
There was a problem hiding this comment.
most of the codes in these 3 if, else if, else block is repeated and can be out of if.
general/mrc20_presale.js
Outdated
| Number(Web3.utils.fromWei(sum, 'ether')) > | ||
| usdMaxCap | ||
| ) | ||
| throw { message: 'Amount is not valid' } |
There was a problem hiding this comment.
what is being checked here in the last else block should also be checked for the previous phases before the public sale.
general/mrc20_presale.js
Outdated
| Number(Web3.utils.fromWei(sum, 'ether')) > | ||
| usdMaxCap | ||
| ) | ||
| throw { message: 'Amount is not valid' } |
There was a problem hiding this comment.
what is being checked here in the last else block should also be checked for the previous phases before the public sale.
| } | ||
| } | ||
| } | ||
| await this.writeNodeMem(memory, 5 * 60) |
There was a problem hiding this comment.
@sadeghte suggested that having such a delay can increase security.
https://github.com/muon-protocol/muon-apps/blob/master/custom/sample.js#L89
| finalMaxCap = maxCap.sub(sum).toString() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
It's safer to check if finalMaxCap > 0 and throw an error otherwise, instead of only relying on smart contract side checking because if in some rare cases it becomes negative, as it's defined as unsigned on, it might result in becoming an attack vector.
batchRequest issue
update recoverTypedSignature
Add pion_tss_reward_oracle app
pion_tss_reward_oracle bugfix
Add `random-words` method to `stage_unitap` app
Get `winnersCount` & check if equals words count (stage_unitap & unitap)
factGPT dispute
Create thena_tc_testenv.js
LayerZeroDVN: testnets
change subgraph to squid
Update thena_tc.js
symmio pion
symmio_pion app
symmio_pion: bugfix
symmio_pion app
Rename symmio apps
layerzero dvn
No description provided.