Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file import and tests #16

Merged
merged 14 commits into from
Feb 1, 2024
Merged

Add file import and tests #16

merged 14 commits into from
Feb 1, 2024

Conversation

juleshaas
Copy link
Contributor

@juleshaas juleshaas commented Jan 23, 2024 •
edited by anikaweinmann
Loading

MR

  • updates administrative_boundaries()
  • restructures and refactors addon
  • adds local file import if data available and overlapping with AOI
  • fix tests for nw and multi fs
  • added tests for sn and bw

@anikaweinmann anikaweinmann changed the title Draft: add file import Add file import and tests Jan 31, 2024
juleshaas
juleshaas commented Feb 1, 2024
View reviewed changes
Copy link
Contributor Author

@juleshaas juleshaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.
I checked the test areas (.geojson). Would it be helpful to have smaller areas for NW and SN? Also the readme file in the test data folder could be updated.

requirements.txt Outdated Show resolved Hide resolved
testsuite/test_v_alkis_buildings_import_BW.py Outdated Show resolved Hide resolved
testsuite/test_v_alkis_buildings_import_SN.py Outdated Show resolved Hide resolved
testsuite/test_v_alkis_buildings_import_SN.py Show resolved Hide resolved
@anikaweinmann
Copy link
Member

I checked the test areas (.geojson). Would it be helpful to have smaller areas for NW and SN?

The tests were running in a ok time. So I would not change now.

@anikaweinmann anikaweinmann merged commit 408bd06 into main Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikaweinmann anikaweinmann anikaweinmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juleshaas @anikaweinmann