(dis)allow multiple var args #1686
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (1)
framework/meta/src/cmd/contract/output_contract/oc_validate.rs|63 col 9| warning: used assert_eq!
with a literal bool
--> framework/meta/src/cmd/contract/output_contract/oc_validate.rs:63:9
|
63 | assert_eq!(endpoint_def.allow_multiple_var_args, false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
= note: #[warn(clippy::bool_assert_comparison)]
on by default
help: replace it with assert!(..)
|
63 - assert_eq!(endpoint_def.allow_multiple_var_args, false);
63 + assert!(!endpoint_def.allow_multiple_var_args);
|
Filtered Findings (17)
vm/src/mem_conv.rs|10 col 9| warning: unknown lint: clippy::needless_pass_by_ref_mut
--> vm/src/mem_conv.rs:10:9
|
10 | #[allow(clippy::needless_pass_by_ref_mut)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: clippy::needless_pass_by_value
|
= note: #[warn(unknown_lints)]
on by default
contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_whitebox_test.rs|64 col 48| warning: redundant clone
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_whitebox_test.rs:64:48
|
64 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_whitebox_test.rs:64:38
|
64 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_blackbox_test.rs|57 col 60| warning: redundant clone
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_blackbox_test.rs:57:60
|
57 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_blackbox_test.rs:57:50
|
57 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs|157 col 48| warning: redundant clone
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:157:48
|
157 | .code(rewards_distribution_code.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:157:23
|
157 | .code(rewards_distribution_code.clone())
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs|359 col 46| warning: redundant clone
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:359:46
|
359 | .multi_esdt_transfer(nft_payments.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:359:34
|
359 | .multi_esdt_transfer(nft_payments.clone())
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/examples/multisig/tests/multisig_blackbox_test.rs|403 col 76| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:403:76
|
403 | let action_id = state.propose_add_board_member(new_board_member_address.clone());
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:403:52
|
403 | let action_id = state.propose_add_board_member(new_board_member_address.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
contracts/examples/multisig/tests/multisig_blackbox_test.rs|458 col 37| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:458:37
|
458 | new_user_address.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:458:21
|
458 | new_user_address.clone(),
| ^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/examples/multisig/tests/multisig_blackbox_test.rs|539 col 69| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:539:69
|
539 | let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:539:52
|
539 | let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
| ^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/examples/multisig/tests/multisig_blackbox_test.rs|568 col 26| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:568:26
|
568 | factorial_address.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:568:9
|
568 | factorial_address.clone(),
| ^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|139 col 47| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:139:47
|
139 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:139:34
|
139 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|269 col 48| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:269:48
|
269 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:269:34
|
269 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|334 col 52| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:334:52
|
334 | .multi_esdt_transfer(combined_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:334:34
|
334 | .multi_esdt_transfer(combined_transfers.clone()),
| ^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|532 col 48| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:532:48
|
532 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:532:34
|
532 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|750 col 47| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:750:47
|
750 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:750:34
|
750 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/composability/forwarder/tests/forwarder_blackbox_test.rs|50 col 45| warning: redundant clone
--> contracts/feature-tests/composability/forwarder/tests/forwarder_blackbox_test.rs:50:45
|
50 | .code(forwarder_code.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/forwarder/tests/forwarder_blackbox_test.rs:50:31
|
50 | .code(forwarder_code.clone())
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
contracts/feature-tests/composability/forwarder/tests/forwarder_whitebox_test.rs|43 col 41| warning: redundant clone
--> contracts/feature-tests/composability/forwarder/tests/forwarder_whitebox_test.rs:43:41
|
43 | .code(forwarder_code.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/forwarder/tests/forwarder_whitebox_test.rs:43:27
|
43 | .code(forwarder_code.clone())
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
vm/src/mem_conv.rs|10 col 9| warning: unknown lint: clippy::needless_pass_by_ref_mut
--> vm/src/mem_conv.rs:10:9
|
10 | #[allow(clippy::needless_pass_by_ref_mut)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: clippy::needless_pass_by_value
|
= note: #[warn(unknown_lints)]
on by default
Annotations
Check warning on line 63 in framework/meta/src/cmd/contract/output_contract/oc_validate.rs
github-actions / clippy
[clippy] framework/meta/src/cmd/contract/output_contract/oc_validate.rs#L63
warning: used `assert_eq!` with a literal bool
--> framework/meta/src/cmd/contract/output_contract/oc_validate.rs:63:9
|
63 | assert_eq!(endpoint_def.allow_multiple_var_args, false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
= note: `#[warn(clippy::bool_assert_comparison)]` on by default
help: replace it with `assert!(..)`
|
63 - assert_eq!(endpoint_def.allow_multiple_var_args, false);
63 + assert!(!endpoint_def.allow_multiple_var_args);
|
Raw output
framework/meta/src/cmd/contract/output_contract/oc_validate.rs:63:9:w:warning: used `assert_eq!` with a literal bool
--> framework/meta/src/cmd/contract/output_contract/oc_validate.rs:63:9
|
63 | assert_eq!(endpoint_def.allow_multiple_var_args, false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
= note: `#[warn(clippy::bool_assert_comparison)]` on by default
help: replace it with `assert!(..)`
|
63 - assert_eq!(endpoint_def.allow_multiple_var_args, false);
63 + assert!(!endpoint_def.allow_multiple_var_args);
|
__END__