Skip to content

Foundry-like tests #225

Foundry-like tests

Foundry-like tests #225

GitHub Actions / clippy failed Oct 8, 2023 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (16)

contracts/foundry/test_multisig/src/test_multisig.rs|57 col 26| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:57:26
|
57 | .get_storage(&multisig, &ManagedBuffer::from(b"quorum"));
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
contracts/foundry/test_multisig/src/test_multisig.rs|64 col 26| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:64:26
|
64 | .get_storage(&multisig, &ManagedBuffer::from(b"num_board_members"));
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|95 col 37| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:95:37
|
95 | self.test_raw().start_prank(&proposer);
| ^^^^^^^^^ help: change this to: proposer
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|97 col 13| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:97:13
|
97 | &multisig,
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|112 col 13| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:112:13
|
112 | &multisig,
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|127 col 13| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:127:13
|
127 | &multisig,
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/foundrylike/src/test_adder.rs|92 col 34| warning: the borrowed expression implements the required traits
--> contracts/foundry/foundrylike/src/test_adder.rs:92:34
|
92 | adder_init_args.push_arg(&value); // initial sum
| ^^^^^^ help: change this to: value
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
contracts/foundry/foundrylike/src/test_adder.rs|105 col 9| warning: you seem to be trying to use match for destructuring a single pattern. Consider using if let
--> contracts/foundry/foundrylike/src/test_adder.rs:105:9
|
105 | / match res {
106 | | Result::Err() => panic!("call failed"),
107 | | Result::Ok(
) => (),
108 | | };
| |^ help: try this: if let Result::Err(_) = res { panic!("call failed") }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: #[warn(clippy::single_match)] on by default
contracts/foundry/foundrylike/src/test_adder.rs|92 col 34| warning: the borrowed expression implements the required traits
--> contracts/foundry/foundrylike/src/test_adder.rs:92:34
|
92 | adder_init_args.push_arg(&value); // initial sum
| ^^^^^^ help: change this to: value
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
contracts/foundry/foundrylike/src/test_adder.rs|105 col 9| warning: you seem to be trying to use match for destructuring a single pattern. Consider using if let
--> contracts/foundry/foundrylike/src/test_adder.rs:105:9
|
105 | / match res {
106 | | Result::Err(
) => panic!("call failed"),
107 | | Result::Ok(
) => (),
108 | | };
| |
__^ help: try this: if let Result::Err(_) = res { panic!("call failed") }
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: #[warn(clippy::single_match)] on by default
contracts/foundry/test_multisig/src/test_multisig.rs|57 col 26| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:57:26
|
57 | .get_storage(&multisig, &ManagedBuffer::from(b"quorum"));
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
contracts/foundry/test_multisig/src/test_multisig.rs|64 col 26| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:64:26
|
64 | .get_storage(&multisig, &ManagedBuffer::from(b"num_board_members"));
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|95 col 37| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:95:37
|
95 | self.test_raw().start_prank(&proposer);
| ^^^^^^^^^ help: change this to: proposer
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|97 col 13| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:97:13
|
97 | &multisig,
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|112 col 13| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:112:13
|
112 | &multisig,
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
contracts/foundry/test_multisig/src/test_multisig.rs|127 col 13| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> contracts/foundry/test_multisig/src/test_multisig.rs:127:13
|
127 | &multisig,
| ^^^^^^^^^ help: change this to: multisig
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Filtered Findings (17)

vm/src/mem_conv.rs|10 col 9| warning: unknown lint: clippy::needless_pass_by_ref_mut
--> vm/src/mem_conv.rs:10:9
|
10 | #[allow(clippy::needless_pass_by_ref_mut)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: clippy::needless_pass_by_value
|
= note: #[warn(unknown_lints)] on by default
vm/src/mem_conv.rs|10 col 9| warning: unknown lint: clippy::needless_pass_by_ref_mut
--> vm/src/mem_conv.rs:10:9
|
10 | #[allow(clippy::needless_pass_by_ref_mut)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: did you mean: clippy::needless_pass_by_value
|
= note: #[warn(unknown_lints)] on by default
contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_whitebox_test.rs|64 col 48| warning: redundant clone
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_whitebox_test.rs:64:48
|
64 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_whitebox_test.rs:64:38
|
64 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs|157 col 48| warning: redundant clone
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:157:48
|
157 | .code(rewards_distribution_code.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:157:23
|
157 | .code(rewards_distribution_code.clone())
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs|359 col 46| warning: redundant clone
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:359:46
|
359 | .multi_esdt_transfer(nft_payments.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/rewards-distribution/tests/rewards_distribution_blackbox_test.rs:359:34
|
359 | .multi_esdt_transfer(nft_payments.clone())
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/composability/forwarder/tests/forwarder_whitebox_test.rs|43 col 41| warning: redundant clone
--> contracts/feature-tests/composability/forwarder/tests/forwarder_whitebox_test.rs:43:41
|
43 | .code(forwarder_code.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/forwarder/tests/forwarder_whitebox_test.rs:43:27
|
43 | .code(forwarder_code.clone())
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/examples/multisig/tests/multisig_blackbox_test.rs|403 col 76| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:403:76
|
403 | let action_id = state.propose_add_board_member(new_board_member_address.clone());
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:403:52
|
403 | let action_id = state.propose_add_board_member(new_board_member_address.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/examples/multisig/tests/multisig_blackbox_test.rs|458 col 37| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:458:37
|
458 | new_user_address.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:458:21
|
458 | new_user_address.clone(),
| ^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/examples/multisig/tests/multisig_blackbox_test.rs|539 col 69| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:539:69
|
539 | let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:539:52
|
539 | let action_id = state.propose_transfer_execute(new_adder_address.clone(), 0u64, adder_call);
| ^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/examples/multisig/tests/multisig_blackbox_test.rs|568 col 26| warning: redundant clone
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:568:26
|
568 | factorial_address.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/examples/multisig/tests/multisig_blackbox_test.rs:568:9
|
568 | factorial_address.clone(),
| ^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_blackbox_test.rs|57 col 60| warning: redundant clone
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_blackbox_test.rs:57:60
|
57 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/transfer-role-features/tests/transfer_role_blackbox_test.rs:57:50
|
57 | Account::new().nonce(1).code(vault_code.clone()),
| ^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|139 col 47| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:139:47
|
139 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:139:34
|
139 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|269 col 48| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:269:48
|
269 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:269:34
|
269 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|334 col 52| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:334:52
|
334 | .multi_esdt_transfer(combined_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:334:34
|
334 | .multi_esdt_transfer(combined_transfers.clone()),
| ^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|532 col 48| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:532:48
|
532 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:532:34
|
532 | .multi_esdt_transfer(esdt_transfers.clone()),
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs|750 col 47| warning: redundant clone
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:750:47
|
750 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/use-module/tests/token_merge_module_whitebox_test.rs:750:34
|
750 | .multi_esdt_transfer(nft_transfers.clone()),
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
contracts/feature-tests/composability/forwarder/tests/forwarder_blackbox_test.rs|50 col 45| warning: redundant clone
--> contracts/feature-tests/composability/forwarder/tests/forwarder_blackbox_test.rs:50:45
|
50 | .code(forwarder_code.clone())
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> contracts/feature-tests/composability/forwarder/tests/forwarder_blackbox_test.rs:50:31
|
50 | .code(forwarder_code.clone())
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default

Annotations

Check warning on line 57 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L57

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:57:26
   |
57 |             .get_storage(&multisig, &ManagedBuffer::from(b"quorum"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:57:26:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:57:26
   |
57 |             .get_storage(&multisig, &ManagedBuffer::from(b"quorum"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 64 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L64

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:64:26
   |
64 |             .get_storage(&multisig, &ManagedBuffer::from(b"num_board_members"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:64:26:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:64:26
   |
64 |             .get_storage(&multisig, &ManagedBuffer::from(b"num_board_members"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 95 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L95

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:95:37
   |
95 |         self.test_raw().start_prank(&proposer);
   |                                     ^^^^^^^^^ help: change this to: `proposer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:95:37:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:95:37
   |
95 |         self.test_raw().start_prank(&proposer);
   |                                     ^^^^^^^^^ help: change this to: `proposer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 97 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L97

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:97:13
   |
97 |             &multisig,
   |             ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:97:13:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:97:13
   |
97 |             &multisig,
   |             ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 112 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L112

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:112:13
    |
112 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:112:13:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:112:13
    |
112 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 127 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L127

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:127:13
    |
127 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:127:13:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:127:13
    |
127 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 92 in contracts/foundry/foundrylike/src/test_adder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/foundrylike/src/test_adder.rs#L92

warning: the borrowed expression implements the required traits
  --> contracts/foundry/foundrylike/src/test_adder.rs:92:34
   |
92 |         adder_init_args.push_arg(&value); // initial sum
   |                                  ^^^^^^ help: change this to: `value`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
contracts/foundry/foundrylike/src/test_adder.rs:92:34:w:warning: the borrowed expression implements the required traits
  --> contracts/foundry/foundrylike/src/test_adder.rs:92:34
   |
92 |         adder_init_args.push_arg(&value); // initial sum
   |                                  ^^^^^^ help: change this to: `value`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 105 in contracts/foundry/foundrylike/src/test_adder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/foundrylike/src/test_adder.rs#L105

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> contracts/foundry/foundrylike/src/test_adder.rs:105:9
    |
105 | /         match res {
106 | |             Result::Err(_) => panic!("call failed"),
107 | |             Result::Ok(_) => (),
108 | |         };
    | |_________^ help: try this: `if let Result::Err(_) = res { panic!("call failed") }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default
Raw output
contracts/foundry/foundrylike/src/test_adder.rs:105:9:w:warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> contracts/foundry/foundrylike/src/test_adder.rs:105:9
    |
105 | /         match res {
106 | |             Result::Err(_) => panic!("call failed"),
107 | |             Result::Ok(_) => (),
108 | |         };
    | |_________^ help: try this: `if let Result::Err(_) = res { panic!("call failed") }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default


__END__

Check warning on line 92 in contracts/foundry/foundrylike/src/test_adder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/foundrylike/src/test_adder.rs#L92

warning: the borrowed expression implements the required traits
  --> contracts/foundry/foundrylike/src/test_adder.rs:92:34
   |
92 |         adder_init_args.push_arg(&value); // initial sum
   |                                  ^^^^^^ help: change this to: `value`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
contracts/foundry/foundrylike/src/test_adder.rs:92:34:w:warning: the borrowed expression implements the required traits
  --> contracts/foundry/foundrylike/src/test_adder.rs:92:34
   |
92 |         adder_init_args.push_arg(&value); // initial sum
   |                                  ^^^^^^ help: change this to: `value`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 105 in contracts/foundry/foundrylike/src/test_adder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/foundrylike/src/test_adder.rs#L105

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> contracts/foundry/foundrylike/src/test_adder.rs:105:9
    |
105 | /         match res {
106 | |             Result::Err(_) => panic!("call failed"),
107 | |             Result::Ok(_) => (),
108 | |         };
    | |_________^ help: try this: `if let Result::Err(_) = res { panic!("call failed") }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default
Raw output
contracts/foundry/foundrylike/src/test_adder.rs:105:9:w:warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> contracts/foundry/foundrylike/src/test_adder.rs:105:9
    |
105 | /         match res {
106 | |             Result::Err(_) => panic!("call failed"),
107 | |             Result::Ok(_) => (),
108 | |         };
    | |_________^ help: try this: `if let Result::Err(_) = res { panic!("call failed") }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default


__END__

Check warning on line 57 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L57

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:57:26
   |
57 |             .get_storage(&multisig, &ManagedBuffer::from(b"quorum"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:57:26:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:57:26
   |
57 |             .get_storage(&multisig, &ManagedBuffer::from(b"quorum"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 64 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L64

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:64:26
   |
64 |             .get_storage(&multisig, &ManagedBuffer::from(b"num_board_members"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:64:26:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:64:26
   |
64 |             .get_storage(&multisig, &ManagedBuffer::from(b"num_board_members"));
   |                          ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 95 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L95

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:95:37
   |
95 |         self.test_raw().start_prank(&proposer);
   |                                     ^^^^^^^^^ help: change this to: `proposer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:95:37:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:95:37
   |
95 |         self.test_raw().start_prank(&proposer);
   |                                     ^^^^^^^^^ help: change this to: `proposer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 97 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L97

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:97:13
   |
97 |             &multisig,
   |             ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:97:13:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> contracts/foundry/test_multisig/src/test_multisig.rs:97:13
   |
97 |             &multisig,
   |             ^^^^^^^^^ help: change this to: `multisig`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 112 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L112

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:112:13
    |
112 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:112:13:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:112:13
    |
112 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__

Check warning on line 127 in contracts/foundry/test_multisig/src/test_multisig.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] contracts/foundry/test_multisig/src/test_multisig.rs#L127

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:127:13
    |
127 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
contracts/foundry/test_multisig/src/test_multisig.rs:127:13:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> contracts/foundry/test_multisig/src/test_multisig.rs:127:13
    |
127 |             &multisig,
    |             ^^^^^^^^^ help: change this to: `multisig`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__