Skip to content

Lottery SC audit fixes #4207

Lottery SC audit fixes

Lottery SC audit fixes #4207

Triggered via pull request December 16, 2024 10:15
Status Success
Total duration 1m 16s
Artifacts

lldb-formatter-tests.yml

on: pull_request
LLDB formatter tests
1m 6s
LLDB formatter tests
Fit to window
Zoom out
Zoom in

Annotations

22 warnings
LLDB formatter tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
LLDB formatter tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
LLDB formatter tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
LLDB formatter tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
LLDB formatter tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
LLDB formatter tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L184: contracts/examples/lottery-esdt/src/lottery.rs#L184
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:184:39 | 184 | if self.total_winning_tickets(&lottery_name).is_empty() { | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L185: contracts/examples/lottery-esdt/src/lottery.rs#L185
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:185:35 | 185 | self.prepare_awarding(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L187: contracts/examples/lottery-esdt/src/lottery.rs#L187
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:187:32 | 187 | self.distribute_prizes(&lottery_name) | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L322: contracts/examples/lottery-esdt/src/lottery.rs#L322
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:322:32 | 322 | self.clear_storage(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L184: contracts/examples/lottery-esdt/src/lottery.rs#L184
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:184:39 | 184 | if self.total_winning_tickets(&lottery_name).is_empty() { | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L185: contracts/examples/lottery-esdt/src/lottery.rs#L185
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:185:35 | 185 | self.prepare_awarding(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L187: contracts/examples/lottery-esdt/src/lottery.rs#L187
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:187:32 | 187 | self.distribute_prizes(&lottery_name) | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L322: contracts/examples/lottery-esdt/src/lottery.rs#L322
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:322:32 | 322 | self.clear_storage(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L184: contracts/examples/lottery-esdt/src/lottery.rs#L184
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:184:39 | 184 | if self.total_winning_tickets(&lottery_name).is_empty() { | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L185: contracts/examples/lottery-esdt/src/lottery.rs#L185
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:185:35 | 185 | self.prepare_awarding(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L187: contracts/examples/lottery-esdt/src/lottery.rs#L187
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:187:32 | 187 | self.distribute_prizes(&lottery_name) | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L322: contracts/examples/lottery-esdt/src/lottery.rs#L322
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:322:32 | 322 | self.clear_storage(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L184: contracts/examples/lottery-esdt/src/lottery.rs#L184
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:184:39 | 184 | if self.total_winning_tickets(&lottery_name).is_empty() { | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L185: contracts/examples/lottery-esdt/src/lottery.rs#L185
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:185:35 | 185 | self.prepare_awarding(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L187: contracts/examples/lottery-esdt/src/lottery.rs#L187
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:187:32 | 187 | self.distribute_prizes(&lottery_name) | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[clippy] contracts/examples/lottery-esdt/src/lottery.rs#L322: contracts/examples/lottery-esdt/src/lottery.rs#L322
warning: this expression creates a reference which is immediately dereferenced by the compiler --> contracts/examples/lottery-esdt/src/lottery.rs:322:32 | 322 | self.clear_storage(&lottery_name); | ^^^^^^^^^^^^^ help: change this to: `lottery_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow