Remove transation outcome and fix changes #539
Conversation
|
|
||
| export class SmartContractResult { | ||
| sender: string; | ||
| receiver: string; | ||
| raw: Record<string, any>; |
There was a problem hiding this comment.
I think this class should have been moved as well, It's fine if it's planned for a future PR.
| data: Buffer.from( | ||
| "QDZmNmJAMDAwMDAwMDAwMDAwMDAwMDAwMDEwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAxMGZmZmZmZg==", | ||
| "base64", | ||
| ), | ||
| logs: scResultLog, | ||
| }); | ||
|
|
||
| const txOutcome = new TransactionOutcome({ smartContractResults: [scResult], logs: logs }); | ||
| const txOutcome = new TransactionOnNetwork({ smartContractResults: [scResult], logs: logs }); |
| @@ -48,7 +33,7 @@ export class DelegationTransactionsOutcomeParser { | |||
| return ""; | |||
| } | |||
| const address = Buffer.from(event.topics[0]); | |||
| return Address.fromBuffer(address).bech32(); | |||
| return new Address(address).bech32(); | |||
There was a problem hiding this comment.
toBech32 could have been used.
src/transactions.ts
Outdated
There was a problem hiding this comment.
this could have been named transactionOnNetwork.ts.
There was a problem hiding this comment.
are these classes still used somewhere?
There was a problem hiding this comment.
I will remove them in the next pr when I remove the result parsers
| @@ -441,7 +390,7 @@ export class TokenManagementTransactionsOutcomeParser { | |||
| return ""; | |||
| } | |||
| const address = Buffer.from(event.topics[3]); | |||
| return Address.fromBuffer(address).bech32(); | |||
| return new Address(address).bech32(); | |||
There was a problem hiding this comment.
use toBech32 here, as well.
| @@ -38,12 +37,12 @@ export class TokenManagementController { | |||
| return transaction; | |||
| } | |||
|
|
|||
| async awaitCompletedIssueFungible(txHash: string): Promise<IESDTIssueOutcome[]> { | |||
| async awaitCompletedIssueFungible(txHash: string): Promise<{ tokenIdentifier: string }[]> { | |||
There was a problem hiding this comment.
So for output objects we don't define types / resources, only for inputs? 💭
| @@ -1,688 +0,0 @@ | |||
| import { assert } from "chai"; | |||
There was a problem hiding this comment.
We should add a future task to re-write these system tests for the new factories / controllers (nice to have).
| @@ -178,21 +177,21 @@ export class Transaction { | |||
| /** | |||
| * Legacy method, use the "sender" property instead. | |||
| */ | |||
| getSender(): IAddress { | |||
| getSender(): Address { | |||
There was a problem hiding this comment.
We should add a task to add the deprecation marker for these legacy functions.
| private readonly firstTopicIsIdentifier: boolean; | ||
|
|
||
| constructor(options: { abi: IAbi; firstTopicIsIdentifier?: boolean }) { | ||
| constructor(options: { abi: AbiRegistry; firstTopicIsIdentifier?: boolean }) { |
There was a problem hiding this comment.
We should add a task to create an alias in v14, so that we have the same name as in PY: Abi. Or to completely rename it.
| data: Uint8Array = new Uint8Array(); | ||
| additionalData: Uint8Array[] = []; |
| Object.assign(this, init); | ||
| } | ||
|
|
||
| static fromHttpResponse(responsePart: { |
There was a problem hiding this comment.
In sdk-py, this conversion is defined somewhere else (network providers module).
src/transactionEvents.ts
Outdated
| let result = new TransactionEvent(); | ||
| result.address = new Address(responsePart.address); | ||
| result.identifier = responsePart.identifier || ""; | ||
| result.topics = (responsePart.topics || []).map((topic) => Buffer.from(topic)); |
There was a problem hiding this comment.
| findFirstOrNoneTopic(predicate: (topic: Uint8Array) => boolean): Uint8Array | undefined { | ||
| return this.topics.filter((topic) => predicate(topic))[0]; | ||
| } | ||
|
|
||
| getLastTopic(): Uint8Array { | ||
| return this.topics[this.topics.length - 1]; | ||
| } |
There was a problem hiding this comment.
If they aren't used anymore, can be dropped (sorry if I'm mistaken, I didn't double check).
There was a problem hiding this comment.
I will remove them in the pr where I remove result parser
No description provided.