Lint project

eslint.config.mjs

@@ -3,15 +3,17 @@ import pluginJs from '@eslint/js';
 import tseslint from 'typescript-eslint';
 import importPlugin from 'eslint-plugin-import';
 import prettierPlugin from 'eslint-plugin-prettier';
+import jestPlugin from 'eslint-plugin-jest';
 
 /** @type {import('eslint').Linter.Config[]} */
 export default [
   {
-    files: ['**/*.{js,mjs,cjs,ts,tsx}'],
+    files: ['**/*.{js,mjs,cjs,ts,tsx}', '**/*.{test,spec}.{js,ts,tsx}'],
     languageOptions: {
       globals: {
         ...globals.browser,
-        ...globals.node
+        ...globals.node,
+        ...globals.jest
       },
       parser: tseslint.parser,
       parserOptions: {
@@ -26,6 +28,7 @@ export default [
     plugins: {
       import: importPlugin,
       prettier: prettierPlugin,
+      jest: jestPlugin,
       '@typescript-eslint': tseslint.plugin
     },
     settings: {
@@ -43,6 +46,7 @@ export default [
       }
     },
     rules: {
+      ...jestPlugin.configs.recommended.rules,
       ...pluginJs.configs.recommended.rules,
       ...tseslint.configs.recommended.rules,
       'import/order': [
@@ -74,21 +78,20 @@ export default [
       '@typescript-eslint/no-empty-function': 'off',
       '@typescript-eslint/no-unused-vars': [
         'error',
-        { argsIgnorePattern: '^_' }
+        {
+          argsIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^_'
+        }
       ],
       '@typescript-eslint/no-var-requires': 'off',
       '@typescript-eslint/explicit-function-return-type': 'off',
       'linebreak-style': ['error', 'unix'],
       quotes: ['error', 'single'],
       semi: ['error', 'always'],
-      'no-unused-vars': [
-        'error',
-        {
-          varsIgnorePattern: '^_',
-          argsIgnorePattern: '^_',
-          destructuredArrayIgnorePattern: '^_'
-        }
-      ],
+      'no-unused-vars': ['off'],
+      'no-prototype-builtins': 'off',
+      'jest/no-mocks-import': 'off',
+      'no-async-promise-executor': 'off',
       'object-curly-newline': 'off',
       'arrow-body-style': 'off',
       'implicit-arrow-linebreak': 'off',

package.json

@@ -25,6 +25,7 @@
     "build-esbuild": "rimraf out && node esbuild.js",
     "build": "yarn build-esbuild && yarn compile",
     "test": "jest",
+    "lint": "eslint --fix src",
     "compile-next": "rimraf out && tsc --p tsconfig.next.json && tsc-alias --project tsconfig.next.json"
   },
   "publishConfig": {
@@ -81,6 +82,7 @@
     "eslint-config-standard": "17.1.0",
     "eslint-import-resolver-typescript": "3.6.3",
     "eslint-plugin-import": "2.31.0",
+    "eslint-plugin-jest": "28.9.0",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-prettier": "5.2.1",
     "eslint-plugin-promise": "7.1.0",

src/__mocks__/utils/mockWindowHistory.ts

@@ -5,11 +5,9 @@ export const mockWindowHistory = () => {
 
   const history = window.history;
 
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   delete window.history;
 
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   window.history = Object.defineProperties(
     {},

src/__mocks__/utils/mockWindowLocation.ts

@@ -5,11 +5,9 @@ export const mockWindowLocation = () => {
 
   const location = window.location;
 
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   delete window.location;
 
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore
   window.location = Object.defineProperties(
     {},

src/apiCalls/account/getAccountFromApi.ts

@@ -20,7 +20,7 @@ export const getAccountFromApi = async (address?: string) => {
   try {
     const { data } = await accountFetcher(address);
     return data as AccountType;
-  } catch (err) {
+  } catch (_err) {
     console.error('error fetching configuration for ', address);
   }
 

src/apiCalls/configuration/getNetworkConfigFromApi.ts

@@ -27,7 +27,7 @@ export async function getNetworkConfigFromApi() {
     if (data != null) {
       return data?.data?.config;
     }
-  } catch (err) {
+  } catch (_err) {
     console.error('error fetching configuration for ', configUrl);
   }
   return null;

src/apiCalls/configuration/getServerConfiguration.ts

@@ -8,7 +8,7 @@ export async function getServerConfiguration(apiAddress: string) {
   try {
     const { data } = await axios.get<NetworkType>(configUrl);
     return data;
-  } catch (err) {
+  } catch (_err) {
     console.error('error fetching configuration for ', configUrl);
   }
   return null;

src/apiCalls/transactions/getTransactionByHash.ts

@@ -1,7 +1,7 @@
 import axios from 'axios';
 import { TRANSACTIONS_ENDPOINT } from 'apiCalls/endpoints';
-import { getState } from 'store/store';
 import { networkSelector } from 'store/selectors';
+import { getState } from 'store/store';
 import { ServerTransactionType } from 'types/serverTransactions.types';
 
 export const getTransactionByHash = (hash: string) => {

src/apiCalls/transactions/getTransactionsByHashes.ts

@@ -1,8 +1,8 @@
 import axios from 'axios';
 import { TRANSACTIONS_ENDPOINT } from 'apiCalls/endpoints';
 
-import { getState } from 'store/store';
 import { networkSelector } from 'store/selectors';
+import { getState } from 'store/store';
 import {
   GetTransactionsByHashesReturnType,
   PendingTransactionsType

src/apiCalls/utils/getScamAddressData.ts

@@ -1,8 +1,8 @@
 import axios from 'axios';
-import { ScamInfoType } from 'types/account.types';
-import { ACCOUNTS_ENDPOINT } from '../endpoints';
 import { networkSelector } from 'store/selectors';
 import { getState } from 'store/store';
+import { ScamInfoType } from 'types/account.types';
+import { ACCOUNTS_ENDPOINT } from '../endpoints';
 
 export async function getScamAddressData(addressToVerify: string) {
   const { apiAddress, apiTimeout } = networkSelector(getState());

src/core/methods/initApp/initApp.ts

@@ -1,12 +1,12 @@
-import { initStore } from 'store/store';
-import { defaultStorageCallback } from 'store/storage';
-import { setNativeAuthConfig } from 'store/actions/config/configActions';
-import { initializeNetwork } from 'store/actions';
-import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
+import { restoreProvider } from 'core/providers/helpers/restoreProvider';
 import { getDefaultNativeAuthConfig } from 'services/nativeAuth/methods/getDefaultNativeAuthConfig';
+import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
+import { initializeNetwork } from 'store/actions';
+import { setNativeAuthConfig } from 'store/actions/config/configActions';
+import { defaultStorageCallback } from 'store/storage';
+import { initStore } from 'store/store';
 import { InitAppType } from './initApp.types';
 import { getIsLoggedIn } from '../account/getIsLoggedIn';
-import { restoreProvider } from 'core/providers/helpers/restoreProvider';
 import { registerWebsocketListener } from './websocket/registerWebsocket';
 import { trackTransactions } from '../trackTransactions/trackTransactions';
 

src/core/methods/initApp/initApp.types.ts

@@ -1,7 +1,7 @@
+import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
 import { StorageCallback } from 'store/storage';
-import { CustomNetworkType } from 'types/network.types';
 import { EnvironmentsEnum } from 'types/enums.types';
-import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
+import { CustomNetworkType } from 'types/network.types';
 
 type BaseDappConfigType = {
   /**

src/core/methods/initApp/websocket/initializeWebsocketConnection.ts

@@ -1,18 +1,18 @@
 import { io } from 'socket.io-client';
-import { retryMultipleTimes } from 'utils/retryMultipleTimes';
-import {
-  BatchTransactionsWSResponseType,
-  websocketConnection,
-  WebsocketConnectionStatusEnum
-} from './websocket.constants';
 import { getWebsocketUrl } from 'apiCalls/websocket';
-import { getStore } from 'store/store';
 import { getAccount } from 'core/methods/account/getAccount';
-import { networkSelector } from 'store/selectors';
 import {
   setWebsocketBatchEvent,
   setWebsocketEvent
 } from 'store/actions/account/accountActions';
+import { networkSelector } from 'store/selectors';
+import { getStore } from 'store/store';
+import { retryMultipleTimes } from 'utils/retryMultipleTimes';
+import {
+  BatchTransactionsWSResponseType,
+  websocketConnection,
+  WebsocketConnectionStatusEnum
+} from './websocket.constants';
 
 const TIMEOUT = 3000;
 const RECONNECTION_ATTEMPTS = 3;
@@ -22,12 +22,15 @@ const BATCH_UPDATED_EVENT = 'batchUpdated';
 const CONNECT = 'connect';
 const DISCONNECT = 'disconnect';
 
+// eslint-disable-next-line no-undef
+type TimeoutType = NodeJS.Timeout | null;
+
 export async function initializeWebsocketConnection() {
   const { address } = getAccount();
   const { apiAddress } = networkSelector(getStore().getState());
 
-  let messageTimeout: NodeJS.Timeout | null = null;
-  let batchTimeout: NodeJS.Timeout | null = null;
+  let messageTimeout: TimeoutType = null;
+  let batchTimeout: TimeoutType = null;
 
   const handleMessageReceived = (message: string) => {
     if (messageTimeout) {

src/core/methods/initApp/websocket/registerWebsocket.ts

@@ -1,6 +1,6 @@
-import { initializeWebsocketConnection } from './initializeWebsocketConnection';
-import { getStore } from 'store/store';
 import { getAccount } from 'core/methods/account/getAccount';
+import { getStore } from 'store/store';
+import { initializeWebsocketConnection } from './initializeWebsocketConnection';
 
 let localAddress = '';
 let closeConnectionRef: () => void;

src/core/methods/sendTransactions/sendTransactions.ts

@@ -1,7 +1,7 @@
 import { Transaction } from '@multiversx/sdk-core/out';
 import { AxiosError } from 'axios';
-import { sendSignedTransactions } from './helpers/sendSignedTransactions';
 import { createTransactionsSession } from 'store/actions/transactions/transactionsActions';
+import { sendSignedTransactions } from './helpers/sendSignedTransactions';
 
 export async function sendTransactions(
   transactions: Transaction[] = []

src/core/methods/trackTransactions/helpers/checkTransactionStatus/checkBatch.ts

@@ -1,29 +1,23 @@
+import { getTransactionsByHashes } from 'apiCalls/transactions/getTransactionsByHashes';
+import {
+  updateSignedTransactionStatus,
+  updateTransactionsSession
+} from 'store/actions/transactions/transactionsActions';
+import { getIsTransactionFailed } from 'store/actions/transactions/transactionStateByStatus';
 import {
   TransactionBatchStatusesEnum,
   TransactionServerStatusesEnum
 } from 'types/enums.types';
+import { ServerTransactionType } from 'types/serverTransactions.types';
+import {
+  GetTransactionsByHashesReturnType,
+  SignedTransactionType
+} from 'types/transactions.types';
 import { refreshAccount } from 'utils/account';
 
 import { getPendingTransactions } from './getPendingTransactions';
 import { manageFailedTransactions } from './manageFailedTransactions';
 import { TransactionsTrackerType } from '../../trackTransactions.types';
-import {
-  GetTransactionsByHashesReturnType,
-  SignedTransactionType
-} from 'types/transactions.types';
-import {
-  BatchTransactionStatus,
-  ServerTransactionType
-} from 'types/serverTransactions.types';
-import {
-  updateSignedTransactionStatus,
-  updateTransactionsSession
-} from 'store/actions/transactions/transactionsActions';
-import {
-  getIsTransactionFailed,
-  getIsTransactionSuccessful
-} from 'store/actions/transactions/transactionStateByStatus';
-import { getTransactionsByHashes } from 'apiCalls/transactions/getTransactionsByHashes';
 
 export interface TransactionStatusTrackerPropsType
   extends TransactionsTrackerType {

src/core/methods/trackTransactions/helpers/checkTransactionStatus/checkTransactionStatus.ts

@@ -1,7 +1,7 @@
 import { refreshAccount } from 'utils/account';
 import { checkBatch } from './checkBatch';
-import { getPendingStoreTransactions } from '../getPendingStoreTransactions';
 import { TransactionsTrackerType } from '../../trackTransactions.types';
+import { getPendingStoreTransactions } from '../getPendingStoreTransactions';
 
 export async function checkTransactionStatus(
   props: TransactionsTrackerType & {

src/core/methods/trackTransactions/trackTransactions.ts

@@ -1,13 +1,13 @@
 import { getTransactionsByHashes as defaultGetTxByHash } from 'apiCalls/transactions/getTransactionsByHashes';
-import { TransactionsTrackerType } from './trackTransactions.types';
-import { getPollingInterval } from './helpers/getPollingInterval';
+import { websocketEventSelector } from 'store/selectors/accountSelectors';
+import { getStore } from 'store/store';
 import { checkTransactionStatus } from './helpers/checkTransactionStatus';
+import { getPollingInterval } from './helpers/getPollingInterval';
+import { TransactionsTrackerType } from './trackTransactions.types';
 import {
   websocketConnection,
   WebsocketConnectionStatusEnum
 } from '../initApp/websocket/websocket.constants';
-import { getStore } from 'store/store';
-import { websocketEventSelector } from 'store/selectors/accountSelectors';
 
 /**
  * Tracks transactions using websocket or polling
@@ -17,6 +17,7 @@ import { websocketEventSelector } from 'store/selectors/accountSelectors';
 export async function trackTransactions(props?: TransactionsTrackerType) {
   const store = getStore();
   const pollingInterval = getPollingInterval();
+  // eslint-disable-next-line no-undef
   let pollingIntervalTimer: NodeJS.Timeout | null = null;
   let timestamp = websocketEventSelector(store.getState())?.timestamp;
 

src/core/providers/DappProvider/helpers/login/helpers/extractAccountFromToken.ts

@@ -1,10 +1,10 @@
-import { setAccount } from 'store/actions/account';
-import { setLoginToken } from 'store/actions/loginInfo/loginInfoActions';
+import { getLatestNonce } from 'core/methods/account/getLatestNonce';
 import { IProvider } from 'core/providers/types/providerFactory.types';
 import { loginAction } from 'store/actions';
+import { setAccount } from 'store/actions/account';
+import { setLoginToken } from 'store/actions/loginInfo/loginInfoActions';
 import { AccountType } from 'types/account.types';
 import { getAccountFromToken } from './getAccountFromToken';
-import { getLatestNonce } from 'core/methods/account/getLatestNonce';
 
 interface IExtractAccountFromTokenProps {
   loginToken: string;

src/core/providers/DappProvider/helpers/login/helpers/getLoginService.ts

@@ -1,12 +1,12 @@
 import { Address, Message } from '@multiversx/sdk-core';
+import { getAccount } from 'core/methods/account/getAccount';
 import { nativeAuth } from 'services/nativeAuth';
 import { buildNativeAuthConfig } from 'services/nativeAuth/methods';
+import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
+import { setTokenLogin } from 'store/actions/loginInfo/loginInfoActions';
 import { networkSelector, tokenLoginSelector } from 'store/selectors';
 import { getState } from 'store/store';
 import { OnProviderLoginType } from 'types/login.types';
-import { setTokenLogin } from 'store/actions/loginInfo/loginInfoActions';
-import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
-import { getAccount } from 'core/methods/account/getAccount';
 
 const getApiAddress = (
   apiAddress: string,

src/core/providers/DappProvider/helpers/login/login.ts

@@ -1,13 +1,13 @@
+import { registerWebsocketListener } from 'core/methods/initApp/websocket/registerWebsocket';
+import { IProvider } from 'core/providers/types/providerFactory.types';
 import { nativeAuth } from 'services/nativeAuth';
+import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
+import { logoutAction } from 'store/actions';
 import { setAddress } from 'store/actions/account';
 import { setTokenLogin } from 'store/actions/loginInfo/loginInfoActions';
-import { IProvider } from 'core/providers/types/providerFactory.types';
 import { nativeAuthConfigSelector } from 'store/selectors';
 import { getState } from 'store/store';
-import { NativeAuthConfigType } from 'services/nativeAuth/nativeAuth.types';
-import { logoutAction } from 'store/actions';
 import { extractAccountFromToken } from './helpers/extractAccountFromToken';
-import { registerWebsocketListener } from 'core/methods/initApp/websocket/registerWebsocket';
 
 async function loginWithoutNativeToken(provider: IProvider) {
   await provider.login();
@@ -36,7 +36,7 @@ async function loginWithNativeToken(
     noCache: true
   });
 
-  const { address, signature, ...loginResult } = await provider.login?.({
+  const { address, signature, ...loginResult } = await provider.login({
     token: loginToken
   });
 

src/core/providers/DappProvider/helpers/signTransactions/helpers/getGuardedTransactions.ts

@@ -1,7 +1,7 @@
 import { Transaction } from '@multiversx/sdk-core';
-import { getAreAllTransactionsSignedByGuardian } from './getAreAllTransactionsSignedByGuardian';
 import { getAccount } from 'core/methods/account/getAccount';
 import { createCrossWindowProvider } from 'core/providers/helpers/crossWindow/createCrossWindowProvider';
+import { getAreAllTransactionsSignedByGuardian } from './getAreAllTransactionsSignedByGuardian';
 
 export async function getGuardedTransactions({
   transactions