Skip to content

[MEX-589] Update deployer sc impl #4283

[MEX-589] Update deployer sc impl

[MEX-589] Update deployer sc impl #4283

GitHub Actions / clippy failed Dec 2, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (3)

dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs|219 col 13| warning: used assert_eq! with a literal bool
--> dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs:219:13
|
219 | assert_eq!(is_blacklisted, false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
= note: #[warn(clippy::bool_assert_comparison)] on by default
help: replace it with assert!(..)
|
219 - assert_eq!(is_blacklisted, false);
219 + assert!(!is_blacklisted);
|
dex/fuzz/src/fuzz_data.rs|404 col 18| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> dex/fuzz/src/fuzz_data.rs:404:18
|
404 | Some(&owner_addr),
| ^^^^^^^^^^^ help: change this to: owner_addr
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default
dex/fuzz/src/fuzz_data.rs|409 col 25| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> dex/fuzz/src/fuzz_data.rs:409:25
|
409 | .execute_tx(&owner_addr, &timestamp_oracle_wrapper, &rust_zero, |sc| {
| ^^^^^^^^^^^ help: change this to: owner_addr
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Filtered Findings (0)

Annotations

Check warning on line 219 in dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs#L219

warning: used `assert_eq!` with a literal bool
   --> dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs:219:13
    |
219 |             assert_eq!(is_blacklisted, false);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
help: replace it with `assert!(..)`
    |
219 -             assert_eq!(is_blacklisted, false);
219 +             assert!(!is_blacklisted);
    |
Raw output
dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs:219:13:w:warning: used `assert_eq!` with a literal bool
   --> dex/proxy-deployer/tests/proxy_deployer_farm_staking_tests.rs:219:13
    |
219 |             assert_eq!(is_blacklisted, false);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
help: replace it with `assert!(..)`
    |
219 -             assert_eq!(is_blacklisted, false);
219 +             assert!(!is_blacklisted);
    |


__END__

Check warning on line 404 in dex/fuzz/src/fuzz_data.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] dex/fuzz/src/fuzz_data.rs#L404

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> dex/fuzz/src/fuzz_data.rs:404:18
    |
404 |             Some(&owner_addr),
    |                  ^^^^^^^^^^^ help: change this to: `owner_addr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
dex/fuzz/src/fuzz_data.rs:404:18:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> dex/fuzz/src/fuzz_data.rs:404:18
    |
404 |             Some(&owner_addr),
    |                  ^^^^^^^^^^^ help: change this to: `owner_addr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default


__END__

Check warning on line 409 in dex/fuzz/src/fuzz_data.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] dex/fuzz/src/fuzz_data.rs#L409

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> dex/fuzz/src/fuzz_data.rs:409:25
    |
409 |             .execute_tx(&owner_addr, &timestamp_oracle_wrapper, &rust_zero, |sc| {
    |                         ^^^^^^^^^^^ help: change this to: `owner_addr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Raw output
dex/fuzz/src/fuzz_data.rs:409:25:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> dex/fuzz/src/fuzz_data.rs:409:25
    |
409 |             .execute_tx(&owner_addr, &timestamp_oracle_wrapper, &rust_zero, |sc| {
    |                         ^^^^^^^^^^^ help: change this to: `owner_addr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow


__END__