Move distribution to legacy #963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psorinionut
approved these changes
Oct 17, 2024
| fn upgrade(&self) {} | ||
|
|
||
| #[endpoint(clearSingleValueMappers)] | ||
| fn clear_single_value_mappers(&self) { |
There was a problem hiding this comment.
So it is ok for this to be called by anyone?
There was a problem hiding this comment.
I don't see why it would be an issue to have it open?
psorinionut
requested changes
Oct 18, 2024
| for _ in 0..n { | ||
| self.community_distribution_list().pop_front(); | ||
| fn clear_community_distribution_list(&self, n: u64) -> (u64, usize) { | ||
| let mut counter = 0; |
There was a problem hiding this comment.
Not really mandatory but would be good to have 2 extra things if we have polished the code.
- rename
nwith something more suggestive, likeelements_to_delete - Add a require that the passed variable (whatever the rename) is > 0. Right now, if you pass 0, it will still remove 1 element.
| } | ||
|
|
||
| #[endpoint(clearUserLockedAssetMap)] | ||
| fn clear_user_locked_asset_map(&self, n: u64) -> usize { | ||
| fn clear_user_locked_asset_map(&self, n: u64) -> (u64, usize) { |
There was a problem hiding this comment.
Also, maybe add a comment about what is returned, like
// Returns number of processed elements and remaining elements in the storage.
psorinionut
previously approved these changes
Oct 18, 2024
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 5e828fd to 35af22b
|
psorinionut
approved these changes
Oct 18, 2024
|
Addressed in PR #965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System test:
https://github.com/lcswillems/xexchange-locked-asset-distribution-system-testing