Farm concentrated liq (part 3) #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
farm-concentrated-liq-part-2
to
feat/concentrated-liq
February 22, 2024 11:42
psorinionut
reviewed
Feb 22, 2024
| @@ -12,6 +13,12 @@ use crate::{ | |||
| pub const DEFAULT_SAFE_PRICE_ROUNDS_OFFSET: u64 = 10 * 60; | |||
| pub const SECONDS_PER_ROUND: u64 = 6; | |||
|
|
|||
| #[derive(TypeAbi, TopEncode, TopDecode, NestedEncode, NestedDecode)] | |||
| pub struct SafePriceLpToken<M: ManagedTypeApi> { | |||
There was a problem hiding this comment.
Why use a struct instead of MultiValue2?
There was a problem hiding this comment.
I would not change the implementation here, as there may be a lot of external contracts that have implemented this feature as it is right now.
There was a problem hiding this comment.
Way easier to integrate into other contracts. You don't need to look into the source code to see what each multi-value means, you simply import the struct.
|
|
||
| fn get_price_bounds(&self, price: &BigUint) -> PriceBounds<Self::Api> { | ||
| let min_ticker = self.min_ticker().get(); | ||
| let lower_bound = price / &min_ticker * &min_ticker; |
There was a problem hiding this comment.
I don't think this is correct
| { | ||
| #[init] | ||
| fn init( | ||
| &self, | ||
| reward_token_id: TokenIdentifier, | ||
| farming_token_id: TokenIdentifier, | ||
| division_safety_constant: BigUint, | ||
| min_ticker: BigUint, |
There was a problem hiding this comment.
What is this? Does it need to be a variable? Maybe have it as a constant?
…tiversx/mx-exchange-sc into farm-concentrated-liq-part-3
|
Contract comparison - from aed9246 to c1ed510
|
CostinCarabas
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.