farm position first audit fixes #3592
psorinionut
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
actions.yml
on: pull_request
Contracts
/
Wasm tests
13m 15s
Contracts
/
Rust tests
4m 6s
Contracts
/
Clippy linter check
1m 56s
Annotations
9 warnings
|
[clippy] dex/farm/src/lib.rs#L231:
dex/farm/src/lib.rs#L231
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> dex/farm/src/lib.rs:231:63
|
231 | let boosted_rewards = self.claim_only_boosted_payment(&user);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
[clippy] dex/farm-with-locked-rewards/src/lib.rs#L233:
dex/farm-with-locked-rewards/src/lib.rs#L233
warning: returning the result of a `let` binding from a block
--> dex/farm-with-locked-rewards/src/lib.rs:240:9
|
233 | / let locked_rewards_payment = self.send_to_lock_contract_non_zero(
234 | | self.reward_token_id().get(),
235 | | boosted_rewards,
236 | | caller.clone(),
237 | | user.clone(),
238 | | );
| |__________- unnecessary `let` binding
239 |
240 | locked_rewards_payment
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
233 ~
234 |
235 ~ self.send_to_lock_contract_non_zero(
236 + self.reward_token_id().get(),
237 + boosted_rewards,
238 + caller.clone(),
239 + user.clone(),
240 + )
|
|
|
[clippy] dex/farm-with-locked-rewards/src/lib.rs#L232:
dex/farm-with-locked-rewards/src/lib.rs#L232
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> dex/farm-with-locked-rewards/src/lib.rs:232:63
|
232 | let boosted_rewards = self.claim_only_boosted_payment(&user);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
[clippy] farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs#L43:
farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs#L43
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs:43:63
|
43 | let boosted_rewards = self.claim_only_boosted_payment(&user);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
[clippy] dex/farm/src/lib.rs#L231:
dex/farm/src/lib.rs#L231
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> dex/farm/src/lib.rs:231:63
|
231 | let boosted_rewards = self.claim_only_boosted_payment(&user);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
[clippy] dex/farm-with-locked-rewards/src/lib.rs#L233:
dex/farm-with-locked-rewards/src/lib.rs#L233
warning: returning the result of a `let` binding from a block
--> dex/farm-with-locked-rewards/src/lib.rs:240:9
|
233 | / let locked_rewards_payment = self.send_to_lock_contract_non_zero(
234 | | self.reward_token_id().get(),
235 | | boosted_rewards,
236 | | caller.clone(),
237 | | user.clone(),
238 | | );
| |__________- unnecessary `let` binding
239 |
240 | locked_rewards_payment
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
233 ~
234 |
235 ~ self.send_to_lock_contract_non_zero(
236 + self.reward_token_id().get(),
237 + boosted_rewards,
238 + caller.clone(),
239 + user.clone(),
240 + )
|
|
|
[clippy] dex/farm-with-locked-rewards/src/lib.rs#L232:
dex/farm-with-locked-rewards/src/lib.rs#L232
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> dex/farm-with-locked-rewards/src/lib.rs:232:63
|
232 | let boosted_rewards = self.claim_only_boosted_payment(&user);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
[clippy] farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs#L43:
farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs#L43
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> farm-staking/farm-staking/src/claim_only_boosted_staking_rewards.rs:43:63
|
43 | let boosted_rewards = self.claim_only_boosted_payment(&user);
| ^^^^^ help: change this to: `user`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
Contracts / Wasm tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
report
Expired
|
46.5 KB |
|
|
report-markdown
Expired
|
2.37 KB |
|